[starnix] Return EAFNOSUPPORT when bind fails

...with an address family mismatch on `AF_INET` (IPv4) sockets.

Bug: b/286855878
Change-Id: Ied3a27ebf9188215ae4c2767d5d558f5bcf4e2d4
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/871678
Fuchsia-Auto-Submit: Ghanan Gowripalan <ghanan@google.com>
Reviewed-by: Kevin Lindkvist <lindkvist@google.com>
Commit-Queue: Ghanan Gowripalan <ghanan@google.com>

Author: ghananigans

src/starnix/kernel/fs/socket/syscalls.rs

@@ -123,7 +123,13 @@ pub fn sys_bind(
     let socket = file.node().socket().ok_or_else(|| errno!(ENOTSOCK))?;
     let address = parse_socket_address(current_task, user_socket_address, address_length)?;
     if !address.valid_for_domain(socket.domain) {
-        return error!(EINVAL);
+        return match socket.domain {
+            SocketDomain::Unix
+            | SocketDomain::Vsock
+            | SocketDomain::Inet6
+            | SocketDomain::Netlink => error!(EINVAL),
+            SocketDomain::Inet => error!(EAFNOSUPPORT),
+        };
     }
     match address {
         SocketAddress::Unspecified => return error!(EINVAL),

src/starnix/tests/gvisor/expectations/default.json5

@@ -410,13 +410,6 @@
                 "PingSocket.PayloadTooLarge",
                 "PingSocket.ReceiveIPPacketInfo",
                 "PingSocket.ReceiveIPv6PktInfo",
-                "PingSockets/Fixture.Bind/ICMP_socket_V6Any",
-                "PingSockets/Fixture.Bind/ICMP_socket_V6Loopback",
-                "PingSockets/Fixture.Bind/ICMP_socket_V6Multicast",
-                "PingSockets/Fixture.Bind/ICMP_socket_V6MulticastInterfaceLocalAllNodes",
-                "PingSockets/Fixture.Bind/ICMP_socket_V6MulticastLinkLocalAllNodes",
-                "PingSockets/Fixture.Bind/ICMP_socket_V6MulticastLinkLocalAllRouters",
-                "PingSockets/Fixture.Bind/ICMP_socket_IPv6UnknownUnicast",
 
                 // pivot_root_test
                 "PivotRootTest.WithoutCapability",

src/starnix/tests/ltp/expectations/ltp.json5

@@ -46,8 +46,6 @@
                 "asapi_01",
                 "asapi_03",
                 "autogroup01",
-                "bind01",
-                "bind01",
                 "bind02",
                 "bind05",
                 "bind06",