Skip to content

Commit a491916

Browse files
authored
Merge pull request #2322 from gluestack/fix/slider-issues
fix: slider issues
2 parents 00c8d2b + a4766ad commit a491916

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

packages/unstyled/slider/src/Slider.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ function Slider<StyledSliderProps>(
2121
'isPressed': isPressedProp,
2222
// @ts-ignore
2323
'aria-label': ariaLabel = 'Slider',
24+
sliderTrackHeight,
25+
step,
2426
children,
2527
...props
2628
}: StyledSliderProps & ISliderProps,
@@ -61,6 +63,7 @@ function Slider<StyledSliderProps>(
6163
numberFormatter: { format: (e) => e },
6264
minValue: props.minValue,
6365
maxValue: props.maxValue,
66+
step,
6467
onChange: (val: any) => {
6568
props.onChange && props.onChange(val[0]);
6669
},
@@ -93,6 +96,7 @@ function Slider<StyledSliderProps>(
9396
setIsHovered,
9497
trackProps,
9598
onTrackLayout: onLayout,
99+
sliderTrackHeight,
96100
};
97101
// eslint-disable-next-line react-hooks/exhaustive-deps
98102
}, [
@@ -114,6 +118,7 @@ function Slider<StyledSliderProps>(
114118
isFocusedProp,
115119
isFocusVisibleProp,
116120
isPressedProp,
121+
sliderTrackHeight,
117122
]);
118123

119124
return (

packages/unstyled/slider/src/SliderTrack.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,15 @@ function SliderTrack<StyledSliderTrackProps>(
1616
isFocusVisible,
1717
isDisabled,
1818
isPressed,
19+
sliderTrackHeight,
1920
} = React.useContext(SliderContext);
2021

2122
return (
2223
<StyledSliderTrack
2324
onLayout={onTrackLayout}
2425
ref={mergeRefs([_ref, ref])}
2526
{...trackProps}
26-
style={style}
27+
style={[{ height: sliderTrackHeight }, style]}
2728
{...props}
2829
isDisabled={isDisabled}
2930
tabIndex={-1}

0 commit comments

Comments
 (0)