Merge pull request #3 from globocom/refactor-options

refactor initialization of options

Author: mbenford

buffer.go

@@ -113,29 +113,12 @@ func newTicker(interval time.Duration) (<-chan time.Time, func()) {
 
 // New creates a new buffer instance with the provided options.
 func New(opts ...Option) *Buffer {
-	options := &Options{
-		Size:          0,
-		Flusher:       nil,
-		FlushInterval: 0,
-		PushTimeout:   time.Second,
-		FlushTimeout:  time.Second,
-		CloseTimeout:  time.Second,
-	}
-
-	for _, opt := range opts {
-		opt(options)
-	}
-
-	if err := validateOptions(options); err != nil {
-		panic(err.Error())
-	}
-
 	buffer := &Buffer{
 		dataCh:  make(chan interface{}),
 		flushCh: make(chan struct{}),
 		closeCh: make(chan struct{}),
 		doneCh:  make(chan struct{}),
-		options: options,
+		options: resolveOptions(opts...),
 	}
 	go buffer.consume()
 

options.go

@@ -92,3 +92,24 @@ func validateOptions(options *Options) error {
 
 	return nil
 }
+
+func resolveOptions(opts ...Option) *Options {
+	options := &Options{
+		Size:          0,
+		Flusher:       nil,
+		FlushInterval: 0,
+		PushTimeout:   time.Second,
+		FlushTimeout:  time.Second,
+		CloseTimeout:  time.Second,
+	}
+
+	for _, opt := range opts {
+		opt(options)
+	}
+
+	if err := validateOptions(options); err != nil {
+		panic(err)
+	}
+
+	return options
+}