feat: use identifier for goto and label

Author: alexander-akait

src/ast.js

@@ -323,18 +323,15 @@ AST.prototype.resolvePrecedence = function(result, parser) {
         result = buffer;
       }
     }
-  } else if (
-    result.kind === "silent" &&
-    !result.expr.parenthesizedExpression
-  ) {
-    if (result.expr.kind === 'assign') return result;
+  } else if (result.kind === "silent" && !result.expr.parenthesizedExpression) {
+    if (result.expr.kind === "assign") return result;
     // overall least precedence
     if (result.expr.right) {
       buffer = result.expr;
       result.expr = buffer.left;
       buffer.left = result;
       this.swapLocations(buffer, buffer.left, buffer.right, parser);
-      result = buffer;  
+      result = buffer;
     }
   }
   return result;

src/parser/statement.js

@@ -353,11 +353,15 @@ module.exports = {
       case this.tok.T_STRING: {
         const result = this.node();
         const current = [this.token, this.lexer.getState()];
-        const label = this.text();
+        const labelNameText = this.text();
+        let labelName = this.node("identifier");
         // AST : https://github.com/php/php-src/blob/master/Zend/zend_language_parser.y#L457
         if (this.next().token === ":") {
+          labelName = labelName(labelNameText);
           this.next();
-          return result("label", label);
+          return result("label", labelName);
+        } else {
+          labelName.destroy();
         }
 
         // default fallback expr / T_STRING '::' (etc...)
@@ -371,12 +375,15 @@ module.exports = {
 
       case this.tok.T_GOTO: {
         const result = this.node("goto");
-        let label = null;
+        let labelName = null;
         if (this.next().expect(this.tok.T_STRING)) {
-          label = this.text();
-          this.next().expectEndOfStatement();
+          labelName = this.node("identifier");
+          const name = this.text();
+          this.next();
+          labelName = labelName(name);
+          this.expectEndOfStatement();
         }
-        return result(label);
+        return result(labelName);
       }
 
       default: {

test/snapshot/__snapshots__/acid.test.js.snap

@@ -3118,7 +3118,23 @@ Program {
                     "offset": 1660,
                   },
                 },
-                "name": "next",
+                "name": Identifier {
+                  "kind": "identifier",
+                  "loc": Location {
+                    "end": Position {
+                      "column": 4,
+                      "line": 83,
+                      "offset": 1664,
+                    },
+                    "source": "next",
+                    "start": Position {
+                      "column": 0,
+                      "line": 83,
+                      "offset": 1660,
+                    },
+                  },
+                  "name": "next",
+                },
               },
               ExpressionStatement {
                 "expression": Assign {
@@ -3663,7 +3679,23 @@ Program {
                 "alternate": null,
                 "body": Goto {
                   "kind": "goto",
-                  "label": "next",
+                  "label": Identifier {
+                    "kind": "identifier",
+                    "loc": Location {
+                      "end": Position {
+                        "column": 49,
+                        "line": 90,
+                        "offset": 1847,
+                      },
+                      "source": "next",
+                      "start": Position {
+                        "column": 45,
+                        "line": 90,
+                        "offset": 1843,
+                      },
+                    },
+                    "name": "next",
+                  },
                   "loc": Location {
                     "end": Position {
                       "column": 50,

test/snapshot/__snapshots__/goto.test.js.snap

@@ -5,7 +5,39 @@ Program {
   "children": Array [
     Goto {
       "kind": "goto",
-      "label": "a",
+      "label": Identifier {
+        "kind": "identifier",
+        "name": "a",
+      },
+    },
+    Echo {
+      "expressions": Array [
+        String {
+          "isDoubleQuote": true,
+          "kind": "string",
+          "raw": "\\"Foo\\"",
+          "unicode": false,
+          "value": "Foo",
+        },
+      ],
+      "kind": "echo",
+      "shortForm": false,
+    },
+  ],
+  "errors": Array [],
+  "kind": "program",
+}
+`;
+
+exports[`goto simple 2`] = `
+Program {
+  "children": Array [
+    Goto {
+      "kind": "goto",
+      "label": Identifier {
+        "kind": "identifier",
+        "name": "longName",
+      },
     },
     Echo {
       "expressions": Array [

test/snapshot/__snapshots__/label.test.js.snap

@@ -5,7 +5,39 @@ Program {
   "children": Array [
     Label {
       "kind": "label",
-      "name": "a",
+      "name": Identifier {
+        "kind": "identifier",
+        "name": "a",
+      },
+    },
+    Echo {
+      "expressions": Array [
+        String {
+          "isDoubleQuote": true,
+          "kind": "string",
+          "raw": "\\"Foo\\"",
+          "unicode": false,
+          "value": "Foo",
+        },
+      ],
+      "kind": "echo",
+      "shortForm": false,
+    },
+  ],
+  "errors": Array [],
+  "kind": "program",
+}
+`;
+
+exports[`label simple 2`] = `
+Program {
+  "children": Array [
+    Label {
+      "kind": "label",
+      "name": Identifier {
+        "kind": "identifier",
+        "name": "longName",
+      },
     },
     Echo {
       "expressions": Array [