Bug fix: Wrap call to ->hasValue() scope in a ->where() closure

bastones · bastones · commit 377d315e0db3 · 2021-06-02T16:34:23.000-04:00
diff --git a/src/Traits/HasCustomFieldResponses.php b/src/Traits/HasCustomFieldResponses.php
@@ -52,7 +52,9 @@ public function scopeWhereField($query, CustomField $field, $value)
         $query->whereHas('customFieldResponses', function ($subQuery) use ($field, $value) {
             $subQuery
                 ->where('field_id', $field->id)
-                ->hasValue($value);
+                ->where(function ($query) use ($value) {
+                    $query->hasValue($value);
+                });
         });
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,9 @@ public function scopeWhereField($query, CustomField $field, $value)`
`52`	`52`	`$query->whereHas('customFieldResponses', function ($subQuery) use ($field, $value) {`
`53`	`53`	`$subQuery`
`54`	`54`	`->where('field_id', $field->id)`
`55`		`- ->hasValue($value);`
	`55`	`+ ->where(function ($query) use ($value) {`
	`56`	`+ $query->hasValue($value);`
	`57`	`+ });`
`56`	`58`	`});`
`57`	`59`	`}`
`58`	`60`	`}`