changes from the review

Author: aiday-mar

src/vs/editor/contrib/zoneWidget/browser/zoneWidget.ts

@@ -31,7 +31,6 @@ export interface IOptions {
 	allowUnlimitedHeight?: boolean;
 	ordinal?: number;
 	showInHiddenAreas?: boolean;
-	allowBehindVerticalScrollbar?: boolean;
 }
 
 export interface IStyles {
@@ -272,7 +271,7 @@ export abstract class ZoneWidget implements IHorizontalSashLayoutProvider {
 	}
 
 	protected _getWidth(info: EditorLayoutInfo): number {
-		return info.width - info.minimap.minimapWidth - (this.options.allowBehindVerticalScrollbar ? 0 : info.verticalScrollbarWidth);
+		return info.width - info.minimap.minimapWidth - info.verticalScrollbarWidth;
 	}
 
 	private _getLeft(info: EditorLayoutInfo): number {

src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts

@@ -199,7 +199,7 @@ export class InlineChatController implements IEditorContribution {
 		assertType(this._strategy);
 		assertType(this._editor.hasModel());
 
-		let widgetPosition: Position | undefined;
+		let widgetPosition: Position;
 		if (initialRender) {
 			widgetPosition = this._editor.getSelection().getEndPosition();
 			this._zone.value.setContainerMargins();
@@ -212,7 +212,7 @@ export class InlineChatController implements IEditorContribution {
 			}
 		}
 		this._zone.value.show(widgetPosition);
-		this._zone.value.updateBackgroundColor(widgetPosition, this._activeSession.selection);
+		this._zone.value.updateBackgroundColor(widgetPosition, this._activeSession.wholeRange.value);
 	}
 
 	protected async _nextState(state: State, options: InlineChatRunOptions | undefined): Promise<void> {

src/vs/workbench/contrib/inlineChat/browser/inlineChatSession.ts

@@ -126,8 +126,7 @@ export class Session {
 		readonly textModelN: ITextModel,
 		readonly provider: IInlineChatSessionProvider,
 		readonly session: IInlineChatSession,
-		readonly wholeRange: SessionWholeRange,
-		readonly selection: IRange
+		readonly wholeRange: SessionWholeRange
 	) {
 		this.textModelNAltVersion = textModelN.getAlternativeVersionId();
 		this._teldata = {
@@ -444,7 +443,7 @@ export class InlineChatSessionService implements IInlineChatSessionService {
 		const wholeRangeMgr = new SessionWholeRange(textModel, wholeRange);
 		store.add(wholeRangeMgr);
 
-		const session = new Session(options.editMode, editor, textModel0, textModel, provider, raw, wholeRangeMgr, editor.getSelection());
+		const session = new Session(options.editMode, editor, textModel0, textModel, provider, raw, wholeRangeMgr);
 
 		// store: key -> session
 		const key = this._key(editor, textModel.uri);

src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts

@@ -6,7 +6,7 @@
 import 'vs/css!./inlineChat';
 import { DisposableStore, MutableDisposable, toDisposable } from 'vs/base/common/lifecycle';
 import { IActiveCodeEditor, ICodeEditor, IDiffEditorConstructionOptions } from 'vs/editor/browser/editorBrowser';
-import { EditorOption } from 'vs/editor/common/config/editorOptions';
+import { EditorLayoutInfo, EditorOption } from 'vs/editor/common/config/editorOptions';
 import { IRange, Range } from 'vs/editor/common/core/range';
 import { localize } from 'vs/nls';
 import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
@@ -701,7 +701,7 @@ export class InlineChatZoneWidget extends ZoneWidget {
 		@IInstantiationService private readonly _instaService: IInstantiationService,
 		@IContextKeyService contextKeyService: IContextKeyService,
 	) {
-		super(editor, { showFrame: false, showArrow: false, isAccessible: true, className: 'inline-chat-widget', keepEditorSelection: true, showInHiddenAreas: true, ordinal: 10000 + 3, allowBehindVerticalScrollbar: true });
+		super(editor, { showFrame: false, showArrow: false, isAccessible: true, className: 'inline-chat-widget', keepEditorSelection: true, showInHiddenAreas: true, ordinal: 10000 + 3 });
 
 		this._ctxVisible = CTX_INLINE_CHAT_VISIBLE.bindTo(contextKeyService);
 		this._ctxCursorPosition = CTX_INLINE_CHAT_OUTER_CURSOR_POSITION.bindTo(contextKeyService);
@@ -771,6 +771,10 @@ export class InlineChatZoneWidget extends ZoneWidget {
 		this._ctxVisible.set(true);
 	}
 
+	override _getWidth(info: EditorLayoutInfo): number {
+		return info.width - info.minimap.minimapWidth - 0;
+	}
+
 	public updateBackgroundColor(position: Position, selection: IRange) {
 		if (!this.container) {
 			return;