Merge pull request microsoft#205706 from microsoft/aiday/addingOptionToSerialize

Adding `isTransient` boolean to the multi diff editor input

Author: aiday-mar

src/vs/workbench/common/editor.ts

@@ -505,6 +505,11 @@ export interface IResourceMultiDiffEditorInput extends IBaseUntypedEditorInput {
 	 * If not set, the resources are dynamically derived from the {@link multiDiffSource}.
 	 */
 	readonly resources?: IResourceDiffEditorInput[];
+
+	/**
+	 * Whether the editor should be serialized and stored for subsequent sessions.
+	 */
+	readonly isTransient?: boolean;
 }
 
 export type IResourceMergeEditorInputSide = (IResourceEditorInput | ITextResourceEditorInput) & { detail?: string };

src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditPane.ts

@@ -351,6 +351,7 @@ export class BulkEditPane extends ViewPane {
 			resources,
 			label,
 			options,
+			isTransient: true,
 			description: label
 		}, e.sideBySide ? SIDE_GROUP : ACTIVE_GROUP);
 	}

src/vs/workbench/contrib/multiDiffEditor/browser/multiDiffEditorInput.ts

@@ -48,6 +48,7 @@ export class MultiDiffEditorInput extends EditorInput implements ILanguageSuppor
 					resource.modified.resource,
 				);
 			}),
+			input.isTransient ?? false
 		);
 	}
 
@@ -59,7 +60,8 @@ export class MultiDiffEditorInput extends EditorInput implements ILanguageSuppor
 			data.resources?.map(resource => new MultiDiffEditorItem(
 				resource.originalUri ? URI.parse(resource.originalUri) : undefined,
 				resource.modifiedUri ? URI.parse(resource.modifiedUri) : undefined,
-			))
+			)),
+			false
 		);
 	}
 
@@ -80,6 +82,7 @@ export class MultiDiffEditorInput extends EditorInput implements ILanguageSuppor
 		public readonly multiDiffSource: URI,
 		public readonly label: string | undefined,
 		public readonly initialResources: readonly MultiDiffEditorItem[] | undefined,
+		public readonly isTransient: boolean = false,
 		@ITextModelService private readonly _textModelService: ITextModelService,
 		@ITextResourceConfigurationService private readonly _textResourceConfigurationService: ITextResourceConfigurationService,
 		@IInstantiationService private readonly _instantiationService: IInstantiationService,
@@ -360,12 +363,15 @@ interface ISerializedMultiDiffEditorInput {
 }
 
 export class MultiDiffEditorSerializer implements IEditorSerializer {
+
+	// TODO@bpasero, @aiday-mar: following canSerialize should be removed (debt item)
 	canSerialize(editor: EditorInput): boolean {
-		return editor instanceof MultiDiffEditorInput;
+		return editor instanceof MultiDiffEditorInput && !editor.isTransient;
 	}
 
 	serialize(editor: MultiDiffEditorInput): string | undefined {
-		return JSON.stringify(editor.serialize());
+		const shouldSerialize = editor instanceof MultiDiffEditorInput && !editor.isTransient;
+		return shouldSerialize ? JSON.stringify(editor.serialize()) : undefined;
 	}
 
 	deserialize(instantiationService: IInstantiationService, serializedEditor: string): EditorInput | undefined {