improve deprecated API reporting (microsoft#186179)

Author: jrieken

src/vs/workbench/api/common/extHostLanguageFeatures.ts

@@ -1041,16 +1041,21 @@ class CompletionsAdapter {
 			return undefined;
 		}
 
-		if (CompletionsAdapter._insertTextIdent(item.insertText) !== CompletionsAdapter._insertTextIdent(resolvedItem.insertText)) {
+		const dto2 = this._convertCompletionItem(resolvedItem, id);
+
+		if (dto1[extHostProtocol.ISuggestDataDtoField.insertText] !== dto2[extHostProtocol.ISuggestDataDtoField.insertText]
+			|| dto1[extHostProtocol.ISuggestDataDtoField.insertTextRules] !== dto2[extHostProtocol.ISuggestDataDtoField.insertTextRules]
+		) {
 			this._apiDeprecation.report('CompletionItem.insertText', this._extension, 'extension MAY NOT change \'insertText\' of a CompletionItem during resolve');
 		}
 
-		if (!equals(item.command, resolvedItem.command)) {
+		if (dto1[extHostProtocol.ISuggestDataDtoField.commandIdent] !== dto2[extHostProtocol.ISuggestDataDtoField.commandIdent]
+			|| dto1[extHostProtocol.ISuggestDataDtoField.commandId] !== dto2[extHostProtocol.ISuggestDataDtoField.commandId]
+			|| !equals(dto1[extHostProtocol.ISuggestDataDtoField.commandArguments], dto2[extHostProtocol.ISuggestDataDtoField.commandArguments])
+		) {
 			this._apiDeprecation.report('CompletionItem.command', this._extension, 'extension MAY NOT change \'command\' of a CompletionItem during resolve');
 		}
 
-		const dto2 = this._convertCompletionItem(resolvedItem, id);
-
 		return {
 			...dto1,
 			[extHostProtocol.ISuggestDataDtoField.documentation]: dto2[extHostProtocol.ISuggestDataDtoField.documentation],
@@ -1068,14 +1073,6 @@ class CompletionsAdapter {
 		};
 	}
 
-	private static _insertTextIdent(insertText: string | vscode.SnippetString | undefined) {
-		switch (typeof insertText) {
-			case 'string': return insertText;
-			case 'undefined': return undefined;
-			case 'object': return insertText.value;
-		}
-	}
-
 	releaseCompletionItems(id: number): any {
 		this._disposables.get(id)?.dispose();
 		this._disposables.delete(id);