Skip to content

Commit c719be7

Browse files
authored
Merge pull request microsoft#187580 from microsoft/aiday/colorPickerPresentationOverlap
Placing the color representation to the right of the codicon in the color picker
2 parents 2f1013a + f73d83f commit c719be7

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/vs/editor/contrib/colorPicker/browser/colorPicker.css

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,19 @@
4848
cursor: pointer;
4949
color: white;
5050
flex: 1;
51+
white-space: nowrap;
52+
overflow: hidden;
53+
}
54+
55+
.colorpicker-header .picked-color .picked-color-presentation {
56+
white-space: nowrap;
57+
margin-left: 5px;
58+
margin-right: 5px;
5159
}
5260

5361
.colorpicker-header .picked-color .codicon {
5462
color: inherit;
5563
font-size: 14px;
56-
position: absolute;
57-
left: 8px;
5864
}
5965

6066
.colorpicker-header .picked-color.light {

src/vs/editor/contrib/colorPicker/browser/colorPickerWidget.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export class ColorPickerHeader extends Disposable {
2626

2727
private readonly _domNode: HTMLElement;
2828
private readonly _pickedColorNode: HTMLElement;
29+
private readonly _pickedColorPresentation: HTMLElement;
2930
private readonly _originalColorNode: HTMLElement;
3031
private readonly _closeButton: CloseButton | null = null;
3132
private backgroundColor: Color;
@@ -37,6 +38,9 @@ export class ColorPickerHeader extends Disposable {
3738
dom.append(container, this._domNode);
3839

3940
this._pickedColorNode = dom.append(this._domNode, $('.picked-color'));
41+
dom.append(this._pickedColorNode, $('span.codicon.codicon-color-mode'));
42+
this._pickedColorPresentation = dom.append(this._pickedColorNode, document.createElement('span'));
43+
this._pickedColorPresentation.classList.add('picked-color-presentation');
4044

4145
const tooltip = localize('clickToToggleColorOptions', "Click to toggle color options (rgb/hsl/hex)");
4246
this._pickedColorNode.setAttribute('title', tooltip);
@@ -91,8 +95,7 @@ export class ColorPickerHeader extends Disposable {
9195
}
9296

9397
private onDidChangePresentation(): void {
94-
this._pickedColorNode.textContent = this.model.presentation ? this.model.presentation.label : '';
95-
this._pickedColorNode.prepend($('.codicon.codicon-color-mode'));
98+
this._pickedColorPresentation.textContent = this.model.presentation ? this.model.presentation.label : '';
9699
}
97100
}
98101

0 commit comments

Comments
 (0)