Skip to content

Commit c53994b

Browse files
authored
SCM - fix repository name text overflow (microsoft#272547)
1 parent 9f92d07 commit c53994b

File tree

2 files changed

+11
-17
lines changed

2 files changed

+11
-17
lines changed

src/vs/workbench/contrib/scm/browser/media/scm.css

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
display: none;
4646
}
4747

48-
.scm-view .scm-provider .monaco-icon-label-container {
49-
display: flex;
48+
.scm-view .scm-provider > .icon {
49+
padding-right: 2px;
5050
}
5151

5252
.scm-view .scm-provider > .monaco-icon-label {
@@ -493,10 +493,6 @@
493493
font-weight: normal;
494494
}
495495

496-
.scm-view.scm-repositories-view .scm-provider .monaco-icon-label-container {
497-
display: flex;
498-
}
499-
500496
/* History item hover */
501497

502498
.monaco-hover.history-item-hover p:first-child {

src/vs/workbench/contrib/scm/browser/scmRepositoryRenderer.ts

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export class RepositoryActionRunner extends ActionRunner {
5151
}
5252

5353
interface RepositoryTemplate {
54+
readonly icon: HTMLElement;
5455
readonly label: IconLabel;
5556
readonly countContainer: HTMLElement;
5657
readonly count: CountBadge;
@@ -83,7 +84,8 @@ export class RepositoryRenderer implements ICompressibleTreeRenderer<ISCMReposit
8384
}
8485

8586
const provider = append(container, $('.scm-provider'));
86-
const label = new IconLabel(provider, { supportIcons: true });
87+
const icon = append(provider, $('.icon'));
88+
const label = new IconLabel(provider, { supportIcons: false });
8789

8890
const actions = append(provider, $('.actions'));
8991
const toolBar = new WorkbenchToolBar(actions, { actionViewItemProvider: this.actionViewItemProvider, resetMenu: this.toolbarMenuId }, this.menuService, this.contextKeyService, this.contextMenuService, this.keybindingService, this.commandService, this.telemetryService);
@@ -93,24 +95,20 @@ export class RepositoryRenderer implements ICompressibleTreeRenderer<ISCMReposit
9395

9496
const templateDisposable = combinedDisposable(label, visibilityDisposable, toolBar);
9597

96-
return { label, countContainer, count, toolBar, elementDisposables: new DisposableStore(), templateDisposable };
98+
return { icon, label, countContainer, count, toolBar, elementDisposables: new DisposableStore(), templateDisposable };
9799
}
98100

99101
renderElement(arg: ISCMRepository | ITreeNode<ISCMRepository, FuzzyScore>, index: number, templateData: RepositoryTemplate): void {
100102
const repository = isSCMRepository(arg) ? arg : arg.element;
101103

102-
const icon = ThemeIcon.isThemeIcon(repository.provider.iconPath)
103-
? repository.provider.iconPath.id
104-
: undefined;
105-
106-
const label = icon
107-
? `$(${icon}) ${repository.provider.name}`
108-
: repository.provider.name;
104+
if (ThemeIcon.isThemeIcon(repository.provider.iconPath)) {
105+
templateData.icon.classList.add(...ThemeIcon.asClassNameArray(repository.provider.iconPath));
106+
}
109107

110108
if (repository.provider.rootUri) {
111-
templateData.label.setLabel(label, repository.provider.label, { title: `${repository.provider.label}: ${repository.provider.rootUri.fsPath}` });
109+
templateData.label.setLabel(repository.provider.name, repository.provider.label, { title: `${repository.provider.label}: ${repository.provider.rootUri.fsPath}` });
112110
} else {
113-
templateData.label.setLabel(label, undefined, { title: repository.provider.label });
111+
templateData.label.setLabel(repository.provider.name, undefined, { title: repository.provider.label });
114112
}
115113

116114
let statusPrimaryActions: IAction[] = [];

0 commit comments

Comments
 (0)