Skip to content

Commit be0da6c

Browse files
committed
Use correct arch
1 parent 2d2226f commit be0da6c

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/treeSitterCommandParser.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import { BugIndicatingError } from '../../../../../base/common/errors.js';
77
import { derived, waitForState } from '../../../../../base/common/observable.js';
8+
import { arch } from '../../../../../base/common/process.js';
89
import { ITreeSitterLibraryService } from '../../../../../editor/common/services/treeSitter/treeSitterLibraryService.js';
910
import type { Language, Parser, Query, QueryCapture } from '@vscode/tree-sitter-wasm';
1011

@@ -84,7 +85,7 @@ export class TreeSitterCommandParser {
8485
private _throwIfCanCrash(languageId: TreeSitterCommandParserLanguage) {
8586
// TODO: The powershell grammar can cause an OOM crash on arm https://github.com/microsoft/vscode/issues/273177
8687
if (
87-
(process.arch === 'arm' || process.arch === 'arm64') &&
88+
(arch === 'arm' || arch === 'arm64') &&
8889
languageId === TreeSitterCommandParserLanguage.PowerShell
8990
) {
9091
throw new Error('powershell grammar is not supported on arm or arm64');

src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import { NullLogService } from '../../../../../../platform/log/common/log.js';
3131
import { IFileService } from '../../../../../../platform/files/common/files.js';
3232
import { Schemas } from '../../../../../../base/common/network.js';
3333
import { TestIPCFileSystemProvider } from '../../../../../test/electron-browser/workbenchTestServices.js';
34+
import { arch } from '../../../../../../base/common/process.js';
3435

3536
class TestRunInTerminalTool extends RunInTerminalTool {
3637
protected override _osBackend: Promise<OperatingSystem> = Promise.resolve(OperatingSystem.Windows);
@@ -45,7 +46,7 @@ class TestRunInTerminalTool extends RunInTerminalTool {
4546
}
4647

4748
// TODO: The powershell grammar can cause an OOM crash on arm https://github.com/microsoft/vscode/issues/273177
48-
(process.arch === 'arm' || process.arch === 'arm64' ? suite.skip : suite)('RunInTerminalTool', () => {
49+
(arch === 'arm' || arch === 'arm64' ? suite.skip : suite)('RunInTerminalTool', () => {
4950
const store = ensureNoDisposablesAreLeakedInTestSuite();
5051

5152
let instantiationService: TestInstantiationService;

src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/treeSitterCommandParser.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ import { NullLogService } from '../../../../../../platform/log/common/log.js';
1414
import { Schemas } from '../../../../../../base/common/network.js';
1515
import { TestIPCFileSystemProvider } from '../../../../../test/electron-browser/workbenchTestServices.js';
1616
import { TreeSitterCommandParser, TreeSitterCommandParserLanguage } from '../../browser/treeSitterCommandParser.js';
17+
import { arch } from '../../../../../../base/common/process.js';
1718

1819
// TODO: The powershell grammar can cause an OOM crash on arm https://github.com/microsoft/vscode/issues/273177
19-
(process.arch === 'arm' || process.arch === 'arm64' ? suite.skip : suite)('TreeSitterCommandParser', () => {
20+
(arch === 'arm' || arch === 'arm64' ? suite.skip : suite)('TreeSitterCommandParser', () => {
2021
const store = ensureNoDisposablesAreLeakedInTestSuite();
2122

2223
let instantiationService: TestInstantiationService;

0 commit comments

Comments
 (0)