worktree error handling in creation of worktrees and checking out branches (microsoft#257328)

* worktree error handling in creation of worktrees  and checking out branches

* code clean up

Author: nguyenchristy

extensions/git/src/commands.ts

@@ -2917,10 +2917,15 @@ export class CommandCenter {
 			try {
 				await item.run(repository, opts);
 			} catch (err) {
-				if (err.gitErrorCode !== GitErrorCodes.DirtyWorkTree) {
+				if (err.gitErrorCode !== GitErrorCodes.DirtyWorkTree && err.gitErrorCode !== GitErrorCodes.WorktreeAlreadyExists) {
 					throw err;
 				}
 
+				if (err.gitErrorCode === GitErrorCodes.WorktreeAlreadyExists) {
+					this.handleWorktreeError(err);
+					return false;
+				}
+
 				const stash = l10n.t('Stash & Checkout');
 				const migrate = l10n.t('Migrate Changes');
 				const force = l10n.t('Force Checkout');
@@ -3458,37 +3463,45 @@ export class CommandCenter {
 		try {
 			await repository.worktree({ name: name, path: worktreePath });
 		} catch (err) {
-			if (err.gitErrorCode === GitErrorCodes.WorktreeAlreadyExists) {
-				const errorMessage = err.stderr;
-				const match = errorMessage.match(/worktree at '([^']+)'/) || errorMessage.match(/'([^']+)'/);
-				const path = match ? match[1] : undefined;
+			if (err.gitErrorCode !== GitErrorCodes.WorktreeAlreadyExists) {
+				throw err;
+			}
 
-				if (!path) {
-					return;
-				}
+			this.handleWorktreeError(err);
+			return;
 
-				const openWorktree = l10n.t('Open in current window');
-				const openWorktreeInNewWindow = l10n.t('Open in new window');
-				const message = l10n.t(errorMessage || 'A worktree for branch \'{0}\' already exists at \'{1}\'.', name, path);
-				const choice = await window.showWarningMessage(message, { modal: true }, openWorktree, openWorktreeInNewWindow);
+		}
+	}
 
-				const worktreeRepository = this.model.getRepository(path) || this.model.getRepository(Uri.file(path));
+	private async handleWorktreeError(err: any): Promise<void> {
+		const errorMessage = err.stderr;
+		const match = errorMessage.match(/worktree at '([^']+)'/) || errorMessage.match(/'([^']+)'/);
+		const path = match ? match[1] : undefined;
 
-				if (!worktreeRepository) {
-					return;
-				}
+		if (!path) {
+			return;
+		}
 
-				if (choice === openWorktree) {
-					await this.openWorktreeInCurrentWindow(worktreeRepository);
-				} else if (choice === openWorktreeInNewWindow) {
-					await this.openWorktreeInNewWindow(worktreeRepository);
-				}
+		const worktreeRepository = this.model.getRepository(path) || this.model.getRepository(Uri.file(path));
 
-				return;
-			}
+		if (!worktreeRepository) {
+			return;
+		}
 
-			throw err;
+		const openWorktree = l10n.t('Open in current window');
+		const openWorktreeInNewWindow = l10n.t('Open in new window');
+		const message = l10n.t(errorMessage);
+		const choice = await window.showWarningMessage(message, { modal: true }, openWorktree, openWorktreeInNewWindow);
+
+
+
+		if (choice === openWorktree) {
+			await this.openWorktreeInCurrentWindow(worktreeRepository);
+		} else if (choice === openWorktreeInNewWindow) {
+			await this.openWorktreeInNewWindow(worktreeRepository);
 		}
+
+		return;
 	}
 
 	@command('git.deleteWorktree', { repository: true })