Polish menu items, add keybindings

Author: Tyriar

src/vs/workbench/contrib/terminal/browser/terminalMenus.ts

@@ -690,7 +690,7 @@ export function getTerminalActionBarArgs(location: ITerminalLocationOptions, pro
 	const submenuActions: IAction[] = [];
 	const splitLocation = (location === TerminalLocation.Editor || (typeof location === 'object' && 'viewColumn' in location && location.viewColumn === ACTIVE_GROUP)) ? { viewColumn: SIDE_GROUP } : { splitActiveTerminal: true };
 
-	dropdownActions.push(disposableStore.add(new Action(TerminalCommandId.New, terminalStrings.newInView, undefined, true, () => terminalService.createAndFocusTerminal())));
+	dropdownActions.push(disposableStore.add(new Action(TerminalCommandId.New, terminalStrings.new, undefined, true, () => terminalService.createAndFocusTerminal())));
 	dropdownActions.push(disposableStore.add(new Action(TerminalCommandId.NewInNewWindow, terminalStrings.newInNewWindow.short, undefined, true, () => terminalService.createAndFocusTerminal({
 		location: { viewColumn: AUX_WINDOW_GROUP }
 	}))));

src/vs/workbench/contrib/terminal/browser/terminalView.ts

@@ -293,7 +293,10 @@ export class TerminalViewPane extends ViewPane {
 			case TerminalCommandId.New: {
 				if (action instanceof MenuItemAction) {
 					const actions = getTerminalActionBarArgs(TerminalLocation.Panel, this._terminalProfileService.availableProfiles, this._getDefaultProfileName(), this._terminalProfileService.contributedProfiles, this._terminalService, this._dropdownMenu, this._disposableStore);
-					this._newDropdown.value = new DropdownWithPrimaryActionViewItem(action, actions.dropdownAction, actions.dropdownMenuActions, actions.className, { hoverDelegate: options.hoverDelegate }, this._contextMenuService, this._keybindingService, this._notificationService, this._contextKeyService, this._themeService, this._accessibilityService);
+					this._newDropdown.value = this._instantiationService.createInstance(DropdownWithPrimaryActionViewItem, action, actions.dropdownAction, actions.dropdownMenuActions, actions.className, {
+						hoverDelegate: options.hoverDelegate,
+						getKeyBinding: (action: IAction) => this._keybindingService.lookupKeybinding(action.id, this._contextKeyService)
+					});
 					this._newDropdown.value?.update(actions.dropdownAction, actions.dropdownMenuActions);
 					return this._newDropdown.value;
 				}

src/vs/workbench/contrib/terminal/common/terminalStrings.ts

@@ -11,7 +11,6 @@ import { localize, localize2 } from '../../../../nls.js';
 export const terminalStrings = {
 	terminal: localize('terminal', "Terminal"),
 	new: localize('terminal.new', "New Terminal"),
-	newInView: localize('terminal.newInView', "New in Terminal View"),
 	doNotShowAgain: localize('doNotShowAgain', 'Do Not Show Again'),
 	currentSessionCategory: localize('currentSessionCategory', 'current session'),
 	previousSessionCategory: localize('previousSessionCategory', 'previous session'),