Skip to content

Commit ab9c8e8

Browse files
committed
Revert lib change for now
Will revisit later
1 parent e68c388 commit ab9c8e8

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/tsconfig.base.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"ES2022",
2020
"DOM",
2121
"DOM.Iterable",
22-
"WebWorker.ImportScripts",
23-
"ESNext.Array"
22+
"WebWorker.ImportScripts"
2423
],
2524
"allowSyntheticDefaultImports": true
2625
}

src/vs/editor/contrib/hover/browser/getHover.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,12 @@ export function getHoverProviderResultsAsAsyncIterable(registry: LanguageFeature
4040
return AsyncIterableObject.fromPromisesResolveOrder(promises).coalesce();
4141
}
4242

43-
export function getHoversPromise(registry: LanguageFeatureRegistry<HoverProvider>, model: ITextModel, position: Position, token: CancellationToken, recursive = false): Promise<Hover[]> {
44-
return Array.fromAsync(
45-
getHoverProviderResultsAsAsyncIterable(registry, model, position, token, recursive),
46-
item => item.hover);
43+
export async function getHoversPromise(registry: LanguageFeatureRegistry<HoverProvider>, model: ITextModel, position: Position, token: CancellationToken, recursive = false): Promise<Hover[]> {
44+
const out: Hover[] = [];
45+
for await (const item of getHoverProviderResultsAsAsyncIterable(registry, model, position, token, recursive)) {
46+
out.push(item.hover);
47+
}
48+
return out;
4749
}
4850

4951
registerModelAndPositionCommand('_executeHoverProvider', (accessor, model, position): Promise<Hover[]> => {

0 commit comments

Comments
 (0)