update todo list validation and add warnings for size and bulk updates (microsoft#264386)

Author: bhavyaus

src/vs/workbench/contrib/chat/browser/chatContentParts/chatTodoListWidget.ts

@@ -118,7 +118,7 @@ export class ChatTodoListWidget extends Disposable {
 		}
 
 		const todoList = this.chatTodoListService.getTodos(sessionId);
-		if (todoList.length > 0) {
+		if (todoList.length > 2) {
 			this.renderTodoList(todoList);
 			this.domNode.style.display = 'block';
 		} else {

src/vs/workbench/contrib/chat/common/tools/manageTodoListTool.ts

@@ -59,7 +59,9 @@ export function createManageTodoListToolData(writeOnly: boolean): IToolData {
 		}
 	};
 
-	const requiredFields = ['todoList'];
+	// Only require the full todoList when operating in write-only mode.
+	// In read/write mode, the write path validates todoList at runtime, so it's not schema-required.
+	const requiredFields = writeOnly ? ['todoList'] : [] as string[];
 
 	if (!writeOnly) {
 		baseProperties.operation = {
@@ -231,9 +233,25 @@ export class ManageTodoListTool extends Disposable implements IToolImpl {
 			status: parsedTodo.status
 		}));
 
+		const existingTodos = this.chatTodoListService.getTodos(chatSessionId);
+		const changes = this.calculateTodoChanges(existingTodos, todoList);
+
 		this.chatTodoListService.setTodos(chatSessionId, todoList);
 		const statusCounts = this.calculateStatusCounts(todoList);
 
+		// Build warnings
+		const warnings: string[] = [];
+		if (todoList.length < 3) {
+			warnings.push('Warning: Small todo list (<3 items). This task might not need a todo list.');
+		}
+		else if (todoList.length > 10) {
+			warnings.push('Warning: Large todo list (>10 items). Consider keeping the list focused and actionable.');
+		}
+
+		if (changes > 3) {
+			warnings.push('Warning: Did you mean to update so many todos at the same time? Consider working on them one by one.');
+		}
+
 		this.telemetryService.publicLog2<TodoListToolInvokedEvent, TodoListToolInvokedClassification>(
 			'todoListToolInvoked',
 			{
@@ -248,7 +266,7 @@ export class ManageTodoListTool extends Disposable implements IToolImpl {
 		return {
 			content: [{
 				kind: 'text',
-				value: 'Successfully wrote todo list'
+				value: `Successfully wrote todo list${warnings.length ? '\n\n' + warnings.join('\n') : ''}`
 			}]
 		};
 	}
@@ -288,6 +306,24 @@ export class ManageTodoListTool extends Disposable implements IToolImpl {
 			return lines.join('\n');
 		}).join('\n');
 	}
+
+	private calculateTodoChanges(oldList: IChatTodo[], newList: IChatTodo[]): number {
+		// Assume arrays are equivalent in order; compare index-by-index
+		let modified = 0;
+		const minLen = Math.min(oldList.length, newList.length);
+		for (let i = 0; i < minLen; i++) {
+			const o = oldList[i];
+			const n = newList[i];
+			if (o.title !== n.title || (o.description ?? '') !== (n.description ?? '') || o.status !== n.status) {
+				modified++;
+			}
+		}
+
+		const added = Math.max(0, newList.length - oldList.length);
+		const removed = Math.max(0, oldList.length - newList.length);
+		const totalChanges = added + removed + modified;
+		return totalChanges;
+	}
 }
 
 type TodoListToolInvokedEvent = {