Fix approach for launching an terminal in aux window

Author: Tyriar

src/vs/workbench/contrib/terminal/browser/terminalActions.ts

@@ -347,15 +347,17 @@ export function registerTerminalActions() {
 	registerTerminalAction({
 		id: TerminalCommandId.NewInNewWindow,
 		title: terminalStrings.newInNewWindow,
-		precondition: ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.webExtensionContributedProfile),
+		precondition: sharedWhenClause.terminalAvailable,
 		keybinding: {
 			primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyMod.Alt | KeyCode.Backquote,
 			mac: { primary: KeyMod.WinCtrl | KeyMod.Shift | KeyMod.Alt | KeyCode.Backquote },
 			weight: KeybindingWeight.WorkbenchContrib
 		},
 		run: async (c) => {
 			const instance = await c.service.createTerminal({
-				location: { viewColumn: AUX_WINDOW_GROUP }
+				location: {
+					viewColumn: AUX_WINDOW_GROUP,
+				}
 			});
 			await instance.focusWhenReady();
 		}

src/vs/workbench/services/editor/common/editorGroupColumn.ts

@@ -6,7 +6,7 @@
 import { IConfigurationService } from '../../../../platform/configuration/common/configuration.js';
 import { GroupIdentifier } from '../../../common/editor.js';
 import { IEditorGroupsService, GroupsOrder, IEditorGroup, preferredSideBySideGroupDirection } from './editorGroupsService.js';
-import { ACTIVE_GROUP, ACTIVE_GROUP_TYPE, SIDE_GROUP, SIDE_GROUP_TYPE } from './editorService.js';
+import { ACTIVE_GROUP, ACTIVE_GROUP_TYPE, AUX_WINDOW_GROUP, SIDE_GROUP, SIDE_GROUP_TYPE } from './editorService.js';
 
 /**
  * A way to address editor groups through a column based system
@@ -16,7 +16,7 @@ import { ACTIVE_GROUP, ACTIVE_GROUP_TYPE, SIDE_GROUP, SIDE_GROUP_TYPE } from './
 export type EditorGroupColumn = number;
 
 export function columnToEditorGroup(editorGroupService: IEditorGroupsService, configurationService: IConfigurationService, column = ACTIVE_GROUP): GroupIdentifier | ACTIVE_GROUP_TYPE | SIDE_GROUP_TYPE {
-	if (column === ACTIVE_GROUP || column === SIDE_GROUP) {
+	if (column === ACTIVE_GROUP || column === SIDE_GROUP || column === AUX_WINDOW_GROUP) {
 		return column; // return early for when column is well known
 	}