Clean up end of function to check approval

Tyriar · Tyriar · commit 901dd69e336c · 2025-08-31T06:11:17.000-07:00
diff --git a/src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts b/src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts
@@ -543,13 +543,14 @@ export class LanguageModelToolsService extends Disposable implements ILanguageMo
 				}],
 			}
 		});
-		if (!promptResult.result) {
-			await this._configurationService.updateValue(ChatConfiguration.GlobalAutoApprove, false);
 
-		} if (promptResult.result === true) {
-			this._storageService.store(AutoApproveStorageKeys.GlobalAutoApproveOptIn, true, StorageScope.APPLICATION, StorageTarget.USER);
+		if (promptResult.result !== true) {
+			await this._configurationService.updateValue(ChatConfiguration.GlobalAutoApprove, false);
+			return false;
 		}
-		return promptResult.result === true;
+
+		this._storageService.store(AutoApproveStorageKeys.GlobalAutoApproveOptIn, true, StorageScope.APPLICATION, StorageTarget.USER);
+		return true;
 	}
 
 	private cleanupCallDisposables(requestId: string | undefined, store: DisposableStore): void {

Original file line number	Diff line number	Diff line change
`@@ -543,13 +543,14 @@ export class LanguageModelToolsService extends Disposable implements ILanguageMo`
`543`	`543`	`}],`
`544`	`544`	`}`
`545`	`545`	`});`
`546`		`- if (!promptResult.result) {`
`547`		`- await this._configurationService.updateValue(ChatConfiguration.GlobalAutoApprove, false);`
`548`	`546`
`549`		`- } if (promptResult.result === true) {`
`550`		`- this._storageService.store(AutoApproveStorageKeys.GlobalAutoApproveOptIn, true, StorageScope.APPLICATION, StorageTarget.USER);`
	`547`	`+ if (promptResult.result !== true) {`
	`548`	`+ await this._configurationService.updateValue(ChatConfiguration.GlobalAutoApprove, false);`
	`549`	`+ return false;`
`551`	`550`	`}`
`552`		`- return promptResult.result === true;`
	`551`	`+`
	`552`	`+ this._storageService.store(AutoApproveStorageKeys.GlobalAutoApproveOptIn, true, StorageScope.APPLICATION, StorageTarget.USER);`
	`553`	`+ return true;`
`553`	`554`	`}`
`554`	`555`
`555`	`556`	`private cleanupCallDisposables(requestId: string \| undefined, store: DisposableStore): void {`