Skip to content

Commit 8fb5ea0

Browse files
deepak1556deepak1556
authored
feat: use custom tag instead of custom version for MS electron releases (microsoft#181309)
* feat: use custom tag instead of custom version for MS electron releases * chore: bump @vscode/gulp-electron * chore: move build id to .yarnrc * chore: rename enableUNCAccessChecks => restrictUNCAccess * chore: update electron@22.3.11 * chore: add build info to about dialog * chore: simplify helper function * chore: remove unused node.js checksums * chore: bump nodejs internal version * chore: bump distro * fix: revert changes to sign.ts * chore: bump distro
1 parent e6de1b0 commit 8fb5ea0

File tree

14 files changed

+40
-58
lines changed

14 files changed

+40
-58
lines changed

‎.yarnrc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
disturl "https://electronjs.org/headers"
2-
target "22.3.10"
2+
target "22.3.11"
3+
ms_build_id "21658788"
34
runtime "electron"
45
build_from_source "true"

‎build/checksums/nodejs.txt‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,7 @@
1-
dfb37570ef34ac04f34c26d0ec558df60a9665df5961c01c1657c0ca495f2f01 node-v16.17.1-aix-ppc64.tar.gz
21
f9f02f7872e2e8ee54320fce13deb9d56904f32bb0615b6e21aa3371d8899150 node-v16.17.1-darwin-arm64.tar.gz
3-
09a45f60bfb9dfbea4f69044dc733ef983945acd92ca89ccccac267f3d71bd44 node-v16.17.1-darwin-arm64.tar.xz
42
3db26761ad8493b894d42260d7e65094b7af9bc473588739e61bc1c32d6ff955 node-v16.17.1-darwin-x64.tar.gz
5-
8e7089956fa01cf7d0045945c0863d282dc6818fb0476237c1396497e29a4254 node-v16.17.1-darwin-x64.tar.xz
6-
35ccb95caf02cda3bd680da4350a8ae5d666a7a9eae3afe5c2a1b3ef29aef108 node-v16.17.1-headers.tar.gz
7-
554c8d1b4b16e0f4c073b9df7c49c893716a3a533f25ac646f23619f5ccee7df node-v16.17.1-headers.tar.xz
83
adc7032888d4e672a4aac886baede8c04fccdd1a2e7ab4bcf325e3f336f44a3d node-v16.17.1-linux-arm64.tar.gz
9-
3dfb8fd8f6b97df69cdc56524abc906c50ef1d0bf091188616802e6c7c731389 node-v16.17.1-linux-arm64.tar.xz
104
aeab05e35f1d2824ecfb88ca321f1408b44d292b2775f2890972c828e00216d0 node-v16.17.1-linux-armv7l.tar.gz
11-
a035ceefb5e16f5fce98c8ddfdf721b96eec20542c72fb8781bcbb6ef20c5550 node-v16.17.1-linux-armv7l.tar.xz
12-
1f48de7bed99e973c4c50f1b7fc99fc9af5144d093fd6d2b50a1e43b5818bf05 node-v16.17.1-linux-ppc64le.tar.gz
13-
70305934661f89fca64053b85317a75f233d5e3fdb2caa6546a19262a519cf20 node-v16.17.1-linux-ppc64le.tar.xz
14-
029dad48018bda07b481213816549b632059fc673c30fdc7a353e04619128344 node-v16.17.1-linux-s390x.tar.gz
15-
1a47f604944c6aff37cb7483503155671cdb34bda9bfb8962007bc440fa04d77 node-v16.17.1-linux-s390x.tar.xz
165
da5658693243b3ecf6a4cba6751a71df1eb9e9703ca93b42a9404aed85f58ad0 node-v16.17.1-linux-x64.tar.gz
17-
06ba2eb34aa385967f5f58c87a44753f83212f6cccea892b33f80a2e7fda8384 node-v16.17.1-linux-x64.tar.xz
18-
12d10476ea7483298364c810c037b9316d1a73dc8c81cfeff7d794aecadde498 node-v16.17.1.pkg
19-
e423985f6019b2026f9a191adb56a96ae83ecd56cdf839cf94aa980168b7a90f node-v16.17.1.tar.gz
20-
6721feb4152d56d2c6b358ce397abd5a7f1daf09ee2e25c5021b9b4d3f86a330 node-v16.17.1.tar.xz
21-
9777e8c4b2864c5b54a0e4e9400f14887db68560a09b94b4113b560a64d1e680 node-v16.17.1-win-x64.7z
22-
ed290151efb417262b9808a70738d4ab79e9d53653a6a9f4b8dd97912e279dce node-v16.17.1-win-x64.zip
23-
0f8101648d5c9e49e89fee541da9e574f899716c32b7c51a732b1766b9fc4526 node-v16.17.1-win-x86.7z
24-
189b5e8b23226403e7b07a46614de19b444d369e694901e3668e2f549799cbcd node-v16.17.1-win-x86.zip
25-
1bdff65fb7642425c0d6826084d63c4be43520316f0ea0b46e6a51999a0ed7fc node-v16.17.1-x64.msi
26-
b737eb23a2c67c253b9364b5284123faf5220d567615bebd4ec4b81070e4d177 node-v16.17.1-x86.msi
276
f518a70dcab7c3fac5b2e1ef100b4f628edfb160f4fafa9a94ef222da8a6e9ab win-x64/node.exe
28-
2f459a64647db493da63c790ce368ad54f59f086d9f22f59c5018680420197b3 win-x64/node.lib
29-
23215ce7d1e9de9777c3407239e7cf18d29d60f757b772219421ab361ac67c74 win-x64/node_pdb.7z
30-
8e32ec12028fd3e3147435be79a858ed9c870aaafa1fcb291362307ef3c47547 win-x64/node_pdb.zip
317
2393aff88be19dbe0205cbde4ff0c1d89911b15de5c99c80f6e5e29604eecd12 win-x86/node.exe
32-
5018c3d42f3fbacbd06cb943b3f2696c8e67ca9bdf6864d0e263d6d6911dffd2 win-x86/node.lib
33-
05a4db56444a60ee70b0d2642d7f2d82a33339894d2d73bd07b1a41d6c869e04 win-x86/node_pdb.7z
34-
8f86eacb7f13a1bf6738cb0819d7854a2abca40fc2e9e1f91421e44ba52cad7e win-x86/node_pdb.zip

‎build/lib/electron.js‎

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎build/lib/electron.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,11 @@ function darwinBundleDocumentTypes(types: { [name: string]: string | string[] },
9090
});
9191
}
9292

93+
const { electronVersion, msBuildId } = util.getElectronVersion();
94+
9395
export const config = {
94-
version: product.electronRepository ? '22.5.7' : util.getElectronVersion(),
96+
version: electronVersion,
97+
tag: product.electronRepository ? `v${electronVersion}-${msBuildId}` : undefined,
9598
productAppName: product.nameLong,
9699
companyName: 'Microsoft Corporation',
97100
copyright: 'Copyright (C) 2023 Microsoft. All rights reserved',
@@ -212,7 +215,7 @@ function getElectron(arch: string): () => NodeJS.ReadWriteStream {
212215
}
213216

214217
async function main(arch = process.arch): Promise<void> {
215-
const version = product.electronRepository ? '22.5.7' : util.getElectronVersion();
218+
const version = electronVersion;
216219
const electronPath = path.join(root, '.build', 'electron');
217220
const versionFile = path.join(electronPath, 'version');
218221
const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

‎build/lib/util.js‎

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎build/lib/util.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -384,10 +384,11 @@ export function streamToPromise(stream: NodeJS.ReadWriteStream): Promise<void> {
384384
});
385385
}
386386

387-
export function getElectronVersion(): string {
387+
export function getElectronVersion(): Record<string, string> {
388388
const yarnrc = fs.readFileSync(path.join(root, '.yarnrc'), 'utf8');
389-
const target = /^target "(.*)"$/m.exec(yarnrc)![1];
390-
return target;
389+
const electronVersion = /^target "(.*)"$/m.exec(yarnrc)![1];
390+
const msBuildId = /^ms_build_id "(.*)"$/m.exec(yarnrc)![1];
391+
return { electronVersion, msBuildId };
391392
}
392393

393394
export function acquireWebNodePaths() {

‎build/linux/debian/install-sysroot.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎build/linux/debian/install-sysroot.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ type SysrootDictEntry = {
3838
};
3939

4040
export async function getSysroot(arch: DebianArchString): Promise<string> {
41-
const sysrootJSONUrl = `https://raw.githubusercontent.com/electron/electron/v${util.getElectronVersion()}/script/sysroots.json`;
41+
const sysrootJSONUrl = `https://raw.githubusercontent.com/electron/electron/v${util.getElectronVersion().electronVersion}/script/sysroots.json`;
4242
const sysrootDictLocation = `${tmpdir()}/sysroots.json`;
4343
const result = spawnSync('curl', [sysrootJSONUrl, '-o', sysrootDictLocation]);
4444
if (result.status !== 0) {

‎cgmanifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@
533533
},
534534
"isOnlyProductionDependency": true,
535535
"license": "MIT",
536-
"version": "22.3.10"
536+
"version": "22.3.11"
537537
},
538538
{
539539
"component": {

‎package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "code-oss-dev",
33
"version": "1.80.0",
4-
"distro": "94a4bd29af2fe03e39c7867fdca1b2e27fed3a39",
4+
"distro": "cbc1aeab0c196a6c6314cf4df21228d9016c70d1",
55
"author": {
66
"name": "Microsoft Corporation"
77
},
@@ -132,7 +132,7 @@
132132
"@typescript-eslint/eslint-plugin": "^5.57.0",
133133
"@typescript-eslint/experimental-utils": "^5.57.0",
134134
"@typescript-eslint/parser": "^5.57.0",
135-
"@vscode/gulp-electron": "^1.34.0",
135+
"@vscode/gulp-electron": "^1.35.0",
136136
"@vscode/l10n-dev": "0.0.21",
137137
"@vscode/telemetry-extractor": "^1.9.9",
138138
"@vscode/test-web": "^0.0.41",
@@ -147,7 +147,7 @@
147147
"cssnano": "^4.1.11",
148148
"debounce": "^1.0.0",
149149
"deemon": "^1.8.0",
150-
"electron": "22.3.10",
150+
"electron": "22.3.11",
151151
"eslint": "8.36.0",
152152
"eslint-plugin-header": "3.1.1",
153153
"eslint-plugin-jsdoc": "^39.3.2",

0 commit comments

Comments
 (0)