Merge pull request microsoft#262753 from mjbvz/quintessential-moth

Don't eagerly create suggest widget when creating chat input

Author: mjbvz

src/vs/editor/contrib/suggest/browser/suggestController.ts

@@ -132,7 +132,10 @@ export class SuggestController implements IEditorContribution {
 	private readonly _selectors = new PriorityRegistry<ISuggestItemPreselector>(s => s.priority);
 
 	private readonly _onWillInsertSuggestItem = new Emitter<{ item: CompletionItem }>();
-	readonly onWillInsertSuggestItem: Event<{ item: CompletionItem }> = this._onWillInsertSuggestItem.event;
+	get onWillInsertSuggestItem() { return this._onWillInsertSuggestItem.event; }
+
+	private _wantsForceRenderingAbove = false;
+
 
 	constructor(
 		editor: ICodeEditor,
@@ -226,6 +229,10 @@ export class SuggestController implements IEditorContribution {
 				}
 			}));
 
+			if (this._wantsForceRenderingAbove) {
+				widget.forceRenderingAbove();
+			}
+
 			return widget;
 		}));
 
@@ -755,15 +762,20 @@ export class SuggestController implements IEditorContribution {
 	}
 
 	forceRenderingAbove() {
-		this.widget.value.forceRenderingAbove();
+		if (this.widget.isInitialized) {
+			this.widget.value.forceRenderingAbove();
+		} else {
+			// Defer this until the widget is created
+			this._wantsForceRenderingAbove = true;
+		}
 	}
 
 	stopForceRenderingAbove() {
-		if (!this.widget.isInitialized) {
-			// This method has no effect if the widget is not initialized yet.
-			return;
+		if (this.widget.isInitialized) {
+			this.widget.value.stopForceRenderingAbove();
+		} else {
+			this._wantsForceRenderingAbove = false;
 		}
-		this.widget.value.stopForceRenderingAbove();
 	}
 
 	registerSelector(selector: ISuggestItemPreselector): IDisposable {