Bump version number and have the editor option reflect the effective value

Author: alexdima

src/vs/editor/common/config/editorOptions.ts

@@ -1651,9 +1651,9 @@ export class EditorFontFamily extends BaseEditorOption<EditorOption.fontFamily,
  */
 export class EditorFontVariations extends BaseEditorOption<EditorOption.fontVariations, boolean | string, string> {
 	// Text is laid out using default settings.
-	public static OFF = '"normal"';
+	public static OFF = 'normal';
 
-	// Translate `fontWeight` config to `font-variation-settings` CSS property.
+	// Translate `fontWeight` config to the `font-variation-settings` CSS property.
 	public static TRANSLATE = 'translate';
 
 	constructor() {
@@ -1694,6 +1694,12 @@ export class EditorFontVariations extends BaseEditorOption<EditorOption.fontVari
 		}
 		return EditorFontVariations.OFF;
 	}
+
+	public override compute(env: IEnvironmentalOptions, options: IComputedEditorOptions, value: string): string {
+		// The value is computed from the fontWeight if it is true.
+		// So take the result from env.fontInfo
+		return env.fontInfo.fontVariationSettings;
+	}
 }
 
 //#endregion

src/vs/editor/common/config/fontInfo.ts

@@ -164,7 +164,7 @@ export class BareFontInfo {
 }
 
 // change this whenever `FontInfo` members are changed
-export const SERIALIZED_FONT_INFO_VERSION = 1;
+export const SERIALIZED_FONT_INFO_VERSION = 2;
 
 export class FontInfo extends BareFontInfo {
 	readonly _editorStylingBrand: void = undefined;