Improve name of pty host connection request

Author: Tyriar

src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts

@@ -23,8 +23,8 @@ export class ElectronPtyHostStarter extends Disposable implements IPtyHostStarte
 
 	private utilityProcess: UtilityProcess | undefined = undefined;
 
-	private readonly _onBeforeWindowConnection = new Emitter<void>();
-	readonly onBeforeWindowConnection = this._onBeforeWindowConnection.event;
+	private readonly _onRequestConnection = new Emitter<void>();
+	readonly onRequestConnection = this._onRequestConnection.event;
 	private readonly _onWillShutdown = new Emitter<void>();
 	readonly onWillShutdown = this._onWillShutdown.event;
 
@@ -104,7 +104,7 @@ export class ElectronPtyHostStarter extends Disposable implements IPtyHostStarte
 	}
 
 	private _onWindowConnection(e: IpcMainEvent, nonce: string) {
-		this._onBeforeWindowConnection.fire();
+		this._onRequestConnection.fire();
 
 		const port = this.utilityProcess!.connect();
 

src/vs/platform/terminal/node/ptyHost.ts

@@ -14,7 +14,7 @@ export interface IPtyHostConnection {
 }
 
 export interface IPtyHostStarter extends IDisposable {
-	onBeforeWindowConnection?: Event<void>;
+	onRequestConnection?: Event<void>;
 	onWillShutdown?: Event<void>;
 
 	/**

src/vs/platform/terminal/node/ptyHostService.ts

@@ -102,10 +102,9 @@ export class PtyHostService extends Disposable implements IPtyService {
 		this._resolveVariablesRequestStore = this._register(new RequestStore(undefined, this._logService));
 		this._resolveVariablesRequestStore.onCreateRequest(this._onPtyHostRequestResolveVariables.fire, this._onPtyHostRequestResolveVariables);
 
-		// Force the pty host to start as the first window is starting if the starter has that
-		// capability
-		if (this._ptyHostStarter.onBeforeWindowConnection) {
-			Event.once(this._ptyHostStarter.onBeforeWindowConnection)(() => this._ensurePtyHost());
+		// Start the pty host when a window requests a connection, if the starter has that capability.
+		if (this._ptyHostStarter.onRequestConnection) {
+			Event.once(this._ptyHostStarter.onRequestConnection)(() => this._ensurePtyHost());
 		}
 
 		this._ptyHostStarter.onWillShutdown?.(() => this._wasQuitRequested = true);