avoid recursion w/ statemachine

Author: jrieken

src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts

@@ -213,11 +213,11 @@ export class InlineChatController implements IEditorContribution {
 		this._zone.value.show(widgetPosition);
 	}
 
-	protected async _nextState(state: State, options: InlineChatRunOptions | undefined): Promise<void> {
-		this._log('setState to ', state);
-		const nextState = await this[state](options);
-		if (nextState) {
-			await this._nextState(nextState, options);
+	protected async _nextState(state: State, options: InlineChatRunOptions): Promise<void> {
+		let nextState: State | void = state;
+		while (nextState) {
+			this._log('setState to ', nextState);
+			nextState = await this[nextState](options);
 		}
 	}
 

src/vs/workbench/contrib/inlineChat/test/browser/inlineChatController.test.ts

@@ -57,10 +57,13 @@ suite('InteractiveChatontroller', function () {
 			});
 		}
 
-		protected override _nextState(state: State, options: InlineChatRunOptions | undefined): Promise<void> {
-			this._onDidChangeState.fire(state);
-			(<State[]>this.states).push(state);
-			return super._nextState(state, options);
+		protected override async _nextState(state: State, options: InlineChatRunOptions): Promise<void> {
+			let nextState: State | void = state;
+			while (nextState) {
+				this._onDidChangeState.fire(nextState);
+				(<State[]>this.states).push(nextState);
+				nextState = await this[nextState](options);
+			}
 		}
 
 		override dispose() {