Merge pull request microsoft#262764 from mjbvz/suspicious-hyena

mjbvz · web-flow · commit 7d35f81ecf4e · 2025-08-21T11:43:44.000-07:00
Skip tracking Disposable.none
diff --git a/src/vs/base/common/lifecycle.ts b/src/vs/base/common/lifecycle.ts
@@ -441,7 +441,7 @@ export class DisposableStore implements IDisposable {
 	 * Add a new {@link IDisposable disposable} to the collection.
 	 */
 	public add<T extends IDisposable>(o: T): T {
-		if (!o) {
+		if (!o || o === Disposable.None) {
 			return o;
 		}
 		if ((o as unknown as DisposableStore) === this) {

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,7 @@ export class DisposableStore implements IDisposable {`
`441`	`441`	`* Add a new {@link IDisposable disposable} to the collection.`
`442`	`442`	`*/`
`443`	`443`	`public add<T extends IDisposable>(o: T): T {`
`444`		`- if (!o) {`
	`444`	`+ if (!o \|\| o === Disposable.None) {`
`445`	`445`	`return o;`
`446`	`446`	`}`
`447`	`447`	`if ((o as unknown as DisposableStore) === this) {`