debug: fix toolbar overlaps traffic lights (microsoft#205127)

connor4312 · web-flow · commit 6289704f0d96 · 2024-02-13T19:22:10.000+01:00
Fixes microsoft#204265
diff --git a/src/vs/workbench/contrib/debug/browser/debugToolBar.ts b/src/vs/workbench/contrib/debug/browser/debugToolBar.ts
@@ -254,7 +254,7 @@ export class DebugToolBar extends Themable implements IWorkbenchContribution {
 			const positionPercentage = isMainWindow
 				? Number(this.storageService.get(DEBUG_TOOLBAR_POSITION_KEY, StorageScope.PROFILE))
 				: this.auxWindowCoordinates.get(currentWindow)?.x;
-			x = positionPercentage !== undefined
+			x = positionPercentage !== undefined && !isNaN(positionPercentage)
 				? positionPercentage * currentWindow.innerWidth
 				: (0.5 * currentWindow.innerWidth - 0.5 * widgetWidth);
 		}

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ export class DebugToolBar extends Themable implements IWorkbenchContribution {`
`254`	`254`	`const positionPercentage = isMainWindow`
`255`	`255`	`? Number(this.storageService.get(DEBUG_TOOLBAR_POSITION_KEY, StorageScope.PROFILE))`
`256`	`256`	`: this.auxWindowCoordinates.get(currentWindow)?.x;`
`257`		`- x = positionPercentage !== undefined`
	`257`	`+ x = positionPercentage !== undefined && !isNaN(positionPercentage)`
`258`	`258`	`? positionPercentage * currentWindow.innerWidth`
`259`	`259`	`: (0.5 * currentWindow.innerWidth - 0.5 * widgetWidth);`
`260`	`260`	`}`