Skip to content

Commit 6145811

Browse files
committed
a11y: Use underlined links in HC themes
1 parent 20501b7 commit 6145811

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

src/vs/platform/theme/common/colorRegistry.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,10 @@ export const selectionBackground = registerColor('selection.background', { light
230230
// ------ text colors
231231

232232
export const textSeparatorForeground = registerColor('textSeparator.foreground', { light: '#0000002e', dark: '#ffffff2e', hcDark: Color.black, hcLight: '#292929' }, nls.localize('textSeparatorForeground', "Color for text separators."));
233-
export const textLinkForeground = registerColor('textLink.foreground', { light: '#006AB1', dark: '#3794FF', hcDark: '#3794FF', hcLight: '#0F4A85' }, nls.localize('textLinkForeground', "Foreground color for links in text."));
234-
export const textLinkActiveForeground = registerColor('textLink.activeForeground', { light: '#006AB1', dark: '#3794FF', hcDark: '#3794FF', hcLight: '#0F4A85' }, nls.localize('textLinkActiveForeground', "Foreground color for links in text when clicked on and on mouse hover."));
233+
234+
export const textLinkForeground = registerColor('textLink.foreground', { light: '#006AB1', dark: '#3794FF', hcDark: '#21A6FF', hcLight: '#0F4A85' }, nls.localize('textLinkForeground', "Foreground color for links in text."));
235+
export const textLinkActiveForeground = registerColor('textLink.activeForeground', { light: '#006AB1', dark: '#3794FF', hcDark: '#21A6FF', hcLight: '#0F4A85' }, nls.localize('textLinkActiveForeground', "Foreground color for links in text when clicked on and on mouse hover."));
236+
235237
export const textPreformatForeground = registerColor('textPreformat.foreground', { light: '#A31515', dark: '#D7BA7D', hcDark: '#000000', hcLight: '#FFFFFF' }, nls.localize('textPreformatForeground', "Foreground color for preformatted text segments."));
236238
export const textPreformatBackground = registerColor('textPreformat.background', { light: '#0000001A', dark: '#FFFFFF1A', hcDark: '#FFFFFF', hcLight: '#09345f' }, nls.localize('textPreformatBackground', "Background color for preformatted text segments."));
237239
export const textBlockQuoteBackground = registerColor('textBlockQuote.background', { light: '#f2f2f2', dark: '#222222', hcDark: null, hcLight: '#F2F2F2' }, nls.localize('textBlockQuoteBackground', "Background color for block quotes in text."));

src/vs/workbench/browser/media/style.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@ body.web {
8787
text-decoration: none;
8888
}
8989

90+
.monaco-workbench.hc-black p > a,
91+
.monaco-workbench.hc-light p > a {
92+
text-decoration: underline !important;
93+
}
94+
9095
.monaco-workbench a:active {
9196
color: inherit;
9297
background-color: inherit;

src/vs/workbench/contrib/chat/browser/media/chat.css

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -207,13 +207,6 @@
207207
color: var(--vscode-textPreformat-foreground);
208208
}
209209

210-
.hc-black .interactive-item-container .value .rendered-markdown a:hover,
211-
.hc-black .interactive-item-container .value .rendered-markdown a:active,
212-
.hc-light .interactive-item-container .value .rendered-markdown a:hover,
213-
.hc-light .interactive-item-container .value .rendered-markdown a:active {
214-
color: var(--vscode-textPreformat-foreground);
215-
}
216-
217210
.interactive-list {
218211
overflow: hidden;
219212
}

0 commit comments

Comments
 (0)