Fixes ProducerConsumer: cannot produce after final value has been set

hediet · hediet · commit 543122191ca9 · 2025-08-22T17:04:30.000+02:00
diff --git a/src/vs/base/common/async.ts b/src/vs/base/common/async.ts
@@ -2430,11 +2430,16 @@ export class AsyncIterableProducer<T> implements AsyncIterable<T> {
 	}
 
 	private _finishOk(): void {
-		this._producerConsumer.produceFinal({ ok: true, value: { done: true, value: undefined } });
+		if (!this._producerConsumer.hasFinalValue) {
+			this._producerConsumer.produceFinal({ ok: true, value: { done: true, value: undefined } });
+		}
 	}
 
 	private _finishError(error: Error): void {
-		this._producerConsumer.produceFinal({ ok: false, error: error });
+		if (!this._producerConsumer.hasFinalValue) {
+			this._producerConsumer.produceFinal({ ok: false, error: error });
+		}
+		// Warning: this can cause to dropped errors.
 	}
 
 	private readonly _iterator: AsyncIterator<T, void, void> = {

Original file line number	Diff line number	Diff line change
`@@ -2430,11 +2430,16 @@ export class AsyncIterableProducer<T> implements AsyncIterable<T> {`
`2430`	`2430`	`}`
`2431`	`2431`
`2432`	`2432`	`private _finishOk(): void {`
`2433`		`- this._producerConsumer.produceFinal({ ok: true, value: { done: true, value: undefined } });`
	`2433`	`+ if (!this._producerConsumer.hasFinalValue) {`
	`2434`	`+ this._producerConsumer.produceFinal({ ok: true, value: { done: true, value: undefined } });`
	`2435`	`+ }`
`2434`	`2436`	`}`
`2435`	`2437`
`2436`	`2438`	`private _finishError(error: Error): void {`
`2437`		`- this._producerConsumer.produceFinal({ ok: false, error: error });`
	`2439`	`+ if (!this._producerConsumer.hasFinalValue) {`
	`2440`	`+ this._producerConsumer.produceFinal({ ok: false, error: error });`
	`2441`	`+ }`
	`2442`	`+ // Warning: this can cause to dropped errors.`
`2438`	`2443`	`}`
`2439`	`2444`
`2440`	`2445`	`private readonly _iterator: AsyncIterator<T, void, void> = {`