debt - try to not cover the entire renderBody in try/catch (microsoft#264343)

Author: bpasero

src/vs/workbench/contrib/chat/browser/chatViewPane.ts

@@ -178,58 +178,53 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 	}
 
 	protected override async renderBody(parent: HTMLElement): Promise<void> {
-		try {
-			super.renderBody(parent);
-
-			this._register(this.instantiationService.createInstance(ChatViewWelcomeController, parent, this, this.chatOptions.location));
-
-			const scopedInstantiationService = this._register(this.instantiationService.createChild(new ServiceCollection([IContextKeyService, this.scopedContextKeyService])));
-			const locationBasedColors = this.getLocationBasedColors();
-			const editorOverflowNode = this.layoutService.getContainer(getWindow(parent)).appendChild($('.chat-editor-overflow.monaco-editor'));
-			this._register({ dispose: () => editorOverflowNode.remove() });
-
-			this._widget = this._register(scopedInstantiationService.createInstance(
-				ChatWidget,
-				this.chatOptions.location,
-				{ viewId: this.id },
-				{
-					autoScroll: mode => mode !== ChatModeKind.Ask,
-					renderFollowups: this.chatOptions.location === ChatAgentLocation.Panel,
-					supportsFileReferences: true,
-					rendererOptions: {
-						renderTextEditsAsSummary: (uri) => {
-							return true;
-						},
-						referencesExpandedWhenEmptyResponse: false,
-						progressMessageAtBottomOfResponse: mode => mode !== ChatModeKind.Ask,
+		super.renderBody(parent);
+
+		this._register(this.instantiationService.createInstance(ChatViewWelcomeController, parent, this, this.chatOptions.location));
+
+		const scopedInstantiationService = this._register(this.instantiationService.createChild(new ServiceCollection([IContextKeyService, this.scopedContextKeyService])));
+		const locationBasedColors = this.getLocationBasedColors();
+		const editorOverflowNode = this.layoutService.getContainer(getWindow(parent)).appendChild($('.chat-editor-overflow.monaco-editor'));
+		this._register({ dispose: () => editorOverflowNode.remove() });
+
+		this._widget = this._register(scopedInstantiationService.createInstance(
+			ChatWidget,
+			this.chatOptions.location,
+			{ viewId: this.id },
+			{
+				autoScroll: mode => mode !== ChatModeKind.Ask,
+				renderFollowups: this.chatOptions.location === ChatAgentLocation.Panel,
+				supportsFileReferences: true,
+				rendererOptions: {
+					renderTextEditsAsSummary: (uri) => {
+						return true;
 					},
-					editorOverflowWidgetsDomNode: editorOverflowNode,
-					enableImplicitContext: this.chatOptions.location === ChatAgentLocation.Panel,
-					enableWorkingSet: 'explicit',
-					supportsChangingModes: true,
+					referencesExpandedWhenEmptyResponse: false,
+					progressMessageAtBottomOfResponse: mode => mode !== ChatModeKind.Ask,
 				},
-				{
-					listForeground: SIDE_BAR_FOREGROUND,
-					listBackground: locationBasedColors.background,
-					overlayBackground: locationBasedColors.overlayBackground,
-					inputEditorBackground: locationBasedColors.background,
-					resultEditorBackground: editorBackground,
-
-				}));
-			this._register(this.onDidChangeBodyVisibility(visible => {
-				this._widget.setVisible(visible);
+				editorOverflowWidgetsDomNode: editorOverflowNode,
+				enableImplicitContext: this.chatOptions.location === ChatAgentLocation.Panel,
+				enableWorkingSet: 'explicit',
+				supportsChangingModes: true,
+			},
+			{
+				listForeground: SIDE_BAR_FOREGROUND,
+				listBackground: locationBasedColors.background,
+				overlayBackground: locationBasedColors.overlayBackground,
+				inputEditorBackground: locationBasedColors.background,
+				resultEditorBackground: editorBackground,
+
 			}));
-			this._register(this._widget.onDidClear(() => this.clear()));
-			this._widget.render(parent);
+		this._register(this.onDidChangeBodyVisibility(visible => {
+			this._widget.setVisible(visible);
+		}));
+		this._register(this._widget.onDidClear(() => this.clear()));
+		this._widget.render(parent);
 
-			const info = this.getTransferredOrPersistedSessionInfo();
-			const model = info.sessionId ? await this.chatService.getOrRestoreSession(info.sessionId) : undefined;
+		const info = this.getTransferredOrPersistedSessionInfo();
+		const model = info.sessionId ? await this.chatService.getOrRestoreSession(info.sessionId) : undefined;
 
-			await this.updateModel(model, info.inputValue || info.mode ? { inputState: { chatMode: info.mode }, inputValue: info.inputValue } : undefined);
-		} catch (e) {
-			this.logService.error(e);
-			throw e;
-		}
+		await this.updateModel(model, info.inputValue || info.mode ? { inputState: { chatMode: info.mode }, inputValue: info.inputValue } : undefined);
 	}
 
 	acceptInput(query?: string): void {