Merge pull request microsoft#204196 from microsoft/tyriar/204195

Fix URL link detection when a path is in query string

Author: Tyriar

src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts

@@ -315,7 +315,7 @@ enum RegexPathConstants {
 	// '":; are allowed in paths but they are often separators so ignore them
 	// Also disallow \\ to prevent a catastropic backtracking case #24795
 	ExcludedPathCharactersClause = '[^\\0<>\\?\\s!`&*()\'":;\\\\]',
-	ExcludedStartPathCharactersClause = '[^\\0<>\\s!`&*()\\[\\]\'":;\\\\]',
+	ExcludedStartPathCharactersClause = '[^\\0<>\\?\\s!`&*()\\[\\]\'":;\\\\]',
 
 	WinOtherPathPrefix = '\\.\\.?|\\~',
 	WinPathSeparatorClause = '(?:\\\\|\\/)',

src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts

@@ -561,6 +561,14 @@ suite('TerminalLinkParsing', () => {
 						] as IParsedLink[]
 					);
 				});
+				test('should not detect links starting with ? within query strings that contain posix-style paths (#204195)', () => {
+					// ? appended to the cwd will exist since it's just the cwd
+					strictEqual(detectLinks(`http://foo.com/?bar=/a/b&baz=c`, os).some(e => e.path.text.startsWith('?')), false);
+				});
+				test('should not detect links starting with ? within query strings that contain Windows-style paths (#204195)', () => {
+					// ? appended to the cwd will exist since it's just the cwd
+					strictEqual(detectLinks(`http://foo.com/?bar=a:\\b&baz=c`, os).some(e => e.path.text.startsWith('?')), false);
+				});
 			}
 		});