Merge pull request microsoft#185429 from microsoft/tyriar/clean_up_traceRpc

Improve safety and remove warning from traceRpc

Author: Tyriar

src/vs/platform/terminal/node/ptyService.ts

@@ -33,32 +33,21 @@ import { join } from 'path';
 import { memoize } from 'vs/base/common/decorators';
 
 export function traceRpc(_target: any, key: string, descriptor: any) {
-	let fnKey: string | null = null;
-	let fn: Function | null = null;
-
-	if (typeof descriptor.value === 'function') {
-		fnKey = 'value';
-		fn = descriptor.value;
-
-		if (fn!.length !== 0) {
-			console.warn('Memoize should only be used in functions with zero parameters');
-		}
-	}
-
-	if (!fn) {
+	if (typeof descriptor.value !== 'function') {
 		throw new Error('not supported');
 	}
-
-	descriptor[fnKey!] = async function (...args: any[]) {
+	const fnKey = 'value';
+	const fn = descriptor.value;
+	descriptor[fnKey] = async function (...args: any[]) {
 		if (this.traceRpcArgs.logService.getLevel() === LogLevel.Trace) {
-			this.traceRpcArgs.logService.trace(`[RPC Request] PtyService#${fn!.name}(${args.map(e => JSON.stringify(e)).join(', ')})`);
+			this.traceRpcArgs.logService.trace(`[RPC Request] PtyService#${fn.name}(${args.map(e => JSON.stringify(e)).join(', ')})`);
 		}
 		if (this.traceRpcArgs.simulatedLatency) {
 			await timeout(this.traceRpcArgs.simulatedLatency);
 		}
-		const result = await fn!.apply(this, args);
+		const result = await fn.apply(this, args);
 		if (this.traceRpcArgs.logService.getLevel() === LogLevel.Trace) {
-			this.traceRpcArgs.logService.trace(`[RPC Response] PtyService#${fn!.name}`, result);
+			this.traceRpcArgs.logService.trace(`[RPC Response] PtyService#${fn.name}`, result);
 		}
 		return result;
 	};