extract iconNameCharacter from doParseLabelWithIcons

Author: aeschli

src/vs/base/common/codicons.ts

@@ -86,6 +86,7 @@ export namespace CSSIcon {
 	export const iconNameSegment = '[A-Za-z0-9]+';
 	export const iconNameExpression = '[A-Za-z0-9\\-]+';
 	export const iconModifierExpression = '~[A-Za-z]+';
+	export const iconNameCharacter = '[A-Za-z0-9\\-~]';
 
 	const cssIconIdRegex = new RegExp(`^(${iconNameExpression})(${iconModifierExpression})?$`);
 

src/vs/base/common/iconLabels.ts

@@ -10,6 +10,7 @@ import { ltrim } from 'vs/base/common/strings';
 export const iconStartMarker = '$(';
 
 const iconsRegex = new RegExp(`\\$\\(${CSSIcon.iconNameExpression}(?:${CSSIcon.iconModifierExpression})?\\)`, 'g'); // no capturing groups
+const iconNameCharacterRegexp = new RegExp(CSSIcon.iconNameCharacter);
 
 const escapeIconsRegex = new RegExp(`(\\\\)?${iconsRegex.source}`, 'g');
 export function escapeIcons(text: string): string {
@@ -103,7 +104,7 @@ function doParseLabelWithIcons(text: string, firstIconIndex: number): IParsedLab
 		// within icon
 		else if (currentIconStart !== -1) {
 			// Make sure this is a real icon name
-			if (/^[a-z0-9\-~]$/i.test(char)) {
+			if (iconNameCharacterRegexp.test(char)) {
 				currentIconValue += char;
 			} else {
 				// This is not a real icon, treat it as text