Make ActionList take a list of menu items directly (microsoft#166750)

We don't need the extra indirection of calling `toMenuItems`

Author: mjbvz

src/vs/platform/actionWidget/browser/actionList.ts

@@ -140,25 +140,20 @@ class ActionItemRenderer<T extends IListMenuItem<IActionItem>> implements IListR
 
 export class ActionList<T extends IActionItem> extends Disposable {
 
-	readonly domNode: HTMLElement;
+	public readonly domNode: HTMLElement;
+
 	private readonly _list: List<IListMenuItem<IActionItem>>;
 
 	private readonly _actionLineHeight = 24;
 	private readonly _headerLineHeight = 26;
 
 	private readonly _allMenuItems: IListMenuItem<IActionItem>[];
 
-	private focusCondition(element: IListMenuItem<IActionItem>): boolean {
-		return !element.disabled && element.kind === ActionListItemKind.Action;
-	}
-
 	constructor(
 		user: string,
-		items: readonly T[],
-		showHeaders: boolean,
+		items: IListMenuItem<T>[],
 		private readonly _delegate: IRenderDelegate,
 		resolver: IActionKeybindingResolver | undefined,
-		toMenuItems: (inputActions: readonly T[], showHeaders: boolean) => IListMenuItem<T>[],
 		@IContextViewService private readonly _contextViewService: IContextViewService,
 		@IKeybindingService private readonly _keybindingService: IKeybindingService
 	) {
@@ -194,11 +189,15 @@ export class ActionList<T extends IActionItem> extends Disposable {
 		this._register(this._list.onDidChangeFocus(() => this._list.domFocus()));
 		this._register(this._list.onDidChangeSelection(e => this.onListSelection(e)));
 
-		this._allMenuItems = toMenuItems(items, showHeaders);
+		this._allMenuItems = items;
 		this._list.splice(0, this._list.length, this._allMenuItems);
 		this.focusNext();
 	}
 
+	private focusCondition(element: IListMenuItem<IActionItem>): boolean {
+		return !element.disabled && element.kind === ActionListItemKind.Action;
+	}
+
 	hide(didCancel?: boolean): void {
 		this._delegate.onHide(didCancel);
 		this._contextViewService.hideContextView();

src/vs/platform/actionWidget/browser/actionWidget.ts

@@ -89,7 +89,7 @@ class ActionWidgetService extends Disposable implements IActionWidgetService {
 
 		this._currentShowingContext = { user, toMenuItems, delegate, actions, anchor, container, options, resolver };
 
-		const list = this._instantiationService.createInstance(ActionList, user, actionsToShow, true, delegate, resolver, toMenuItems);
+		const list = this._instantiationService.createInstance(ActionList, user, toMenuItems(actionsToShow, true), delegate, resolver);
 		this.contextViewService.showContextView({
 			getAnchor: () => anchor,
 			render: (container: HTMLElement) => {