remove unused event, dispose new event (microsoft#205190)

Author: jrieken

src/vs/workbench/api/common/extHostChatProvider.ts

@@ -90,7 +90,6 @@ export class ExtHostChatProvider implements ExtHostChatProviderShape {
 	private static _idPool = 1;
 
 	private readonly _proxy: MainThreadChatProviderShape;
-	private readonly _onDidChangeAccess = new Emitter<ExtensionIdentifierSet>();
 	private readonly _onDidChangeModelAccess = new Emitter<{ from: ExtensionIdentifier; to: ExtensionIdentifier }>();
 	private readonly _onDidChangeProviders = new Emitter<vscode.LanguageModelChangeEvent>();
 	readonly onDidChangeProviders = this._onDidChangeProviders.event;
@@ -110,7 +109,7 @@ export class ExtHostChatProvider implements ExtHostChatProviderShape {
 	}
 
 	dispose(): void {
-		this._onDidChangeAccess.dispose();
+		this._onDidChangeModelAccess.dispose();
 		this._onDidChangeProviders.dispose();
 	}
 
@@ -238,10 +237,9 @@ export class ExtHostChatProvider implements ExtHostChatProviderShape {
 				return (that._isUsingAuth(from, metadata) && !that._modelAccessList.get(from)?.has(metadata.extension)) || !that._languageModelIds.has(languageModelId);
 			},
 			get onDidChangeAccess() {
-				const onDidChangeAccess = Event.filter(that._onDidChangeAccess.event, set => set.has(from));
 				const onDidRemoveLM = Event.filter(that._onDidChangeProviders.event, e => e.removed.includes(languageModelId));
 				const onDidChangeModelAccess = Event.filter(that._onDidChangeModelAccess.event, e => ExtensionIdentifier.equals(e.from, from) && ExtensionIdentifier.equals(e.to, metadata.extension));
-				return Event.signal(Event.any(onDidChangeAccess, onDidRemoveLM, onDidChangeModelAccess));
+				return Event.signal(Event.any(onDidRemoveLM, onDidChangeModelAccess));
 			},
 			makeChatRequest(messages, options, token) {
 				if (that._isUsingAuth(from, metadata) && !that._modelAccessList.get(from)?.has(metadata.extension)) {