Merge pull request microsoft#259813 from microsoft/tyriar/259668_2

Add more safe commands

Author: Tyriar

src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts

@@ -89,35 +89,47 @@ export const terminalChatAgentToolsConfiguration: IStringDictionary<IConfigurati
 		default: {
 			// Safe and common readonly commands (automatically approved)
 			echo: true,
-			'Write-Host': true,
-			'Write-Output': true,
 			ls: true,
 			find: true,
-			'Get-ChildItem': true,
 			pwd: true,
-			'Get-Location': true,
 			cat: true,
 			head: true,
 			tail: true,
-			'Get-Content': true,
 			grep: true,
 			wc: true,
-			'Select-Object': true,
-			'Select-String': true,
-			'Where-Obejct': true,
-			'Measure-Object': true,
 			sort: true,
 			uniq: true,
-			'Sort-Object': true,
+			tr: true,
 			which: true,
-			'Get-Command': true,
 			date: true,
-			'Get-Date': true,
+			time: true,
+			env: true,
+			printenv: true,
+			uname: true,
 			hostname: true,
-			'Get-Host': true,
 			ps: true,
-			'Get-Process': true,
 			whoami: true,
+			basename: true,
+			dirname: true,
+			realpath: true,
+			readlink: true,
+			stat: true,
+			file: true,
+			du: true,
+			df: true,
+			// While these PowerShell verbs can have side effects, they are generally innocuous (eg.
+			// updating OS-level file access info) and and often have prompts if they're more
+			// involved (eg. Get-Credential)
+			'/Get-[a-z0-9]/i': true,
+			'/Select-[a-z0-9]/i': true,
+			'/Measure-[a-z0-9]/i': true,
+			'/Compare-[a-z0-9]/i': true,
+			'/Format-[a-z0-9]/i': true,
+			'/Sort-[a-z0-9]/i': true,
+			'Write-Host': true,
+			'Write-Output': true,
+			'Split-Path': true,
+			'Join-Path': true,
 
 			// There are countless dangerous commands available on the command line, the defaults here
 			// include common ones that the user is likely to want to explicitly approve first. This is