Skip to content

Commit 1bf42e4

Browse files
authored
Merge pull request microsoft#262754 from mjbvz/elderly-locust
User getters for events on a few common types
2 parents a97045d + 13109e3 commit 1bf42e4

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

src/vs/base/browser/ui/resizable/resizable.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ export class ResizableHTMLElement {
2323
readonly domNode: HTMLElement;
2424

2525
private readonly _onDidWillResize = new Emitter<void>();
26-
readonly onDidWillResize: Event<void> = this._onDidWillResize.event;
26+
get onDidWillResize() { return this._onDidWillResize.event; }
2727

2828
private readonly _onDidResize = new Emitter<IResizeEvent>();
29-
readonly onDidResize: Event<IResizeEvent> = this._onDidResize.event;
29+
get onDidResize() { return this._onDidResize.event; }
3030

3131
private readonly _northSash: Sash;
3232
private readonly _eastSash: Sash;

src/vs/base/browser/ui/sash/sash.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,23 +296,23 @@ export class Sash extends Disposable {
296296
/**
297297
* An event which fires whenever the user starts dragging this sash.
298298
*/
299-
readonly onDidStart: Event<ISashEvent> = this._onDidStart.event;
299+
get onDidStart() { return this._onDidStart.event; }
300300

301301
/**
302302
* An event which fires whenever the user moves the mouse while
303303
* dragging this sash.
304304
*/
305-
readonly onDidChange: Event<ISashEvent> = this._onDidChange.event;
305+
get onDidChange() { return this._onDidChange.event; }
306306

307307
/**
308308
* An event which fires whenever the user double clicks this sash.
309309
*/
310-
readonly onDidReset: Event<void> = this._onDidReset.event;
310+
get onDidReset() { return this._onDidReset.event; }
311311

312312
/**
313313
* An event which fires whenever the user stops dragging this sash.
314314
*/
315-
readonly onDidEnd: Event<void> = this._onDidEnd.event;
315+
get onDidEnd() { return this._onDidEnd.event; }
316316

317317
/**
318318
* A linked sash will be forwarded the same user interactions and events

src/vs/base/browser/ui/toolbar/toolbar.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ export class ToolBar extends Disposable {
6161
private readonly element: HTMLElement;
6262

6363
private _onDidChangeDropdownVisibility = this._register(new EventMultiplexer<boolean>());
64-
readonly onDidChangeDropdownVisibility = this._onDidChangeDropdownVisibility.event;
64+
get onDidChangeDropdownVisibility() { return this._onDidChangeDropdownVisibility.event; }
65+
6566
private readonly disposables = this._register(new DisposableStore());
6667

6768
constructor(container: HTMLElement, contextMenuProvider: IContextMenuProvider, options: IToolBarOptions = { orientation: ActionsOrientation.HORIZONTAL }) {

src/vs/platform/actions/browser/toolbar.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { IAction, Separator, SubmenuAction, toAction, WorkbenchActionExecutedCla
1010
import { coalesceInPlace } from '../../../base/common/arrays.js';
1111
import { intersection } from '../../../base/common/collections.js';
1212
import { BugIndicatingError } from '../../../base/common/errors.js';
13-
import { Emitter, Event } from '../../../base/common/event.js';
13+
import { Emitter } from '../../../base/common/event.js';
1414
import { Iterable } from '../../../base/common/iterator.js';
1515
import { DisposableStore } from '../../../base/common/lifecycle.js';
1616
import { localize } from '../../../nls.js';
@@ -335,7 +335,7 @@ export interface IMenuWorkbenchToolBarOptions extends IWorkbenchToolBarOptions {
335335
export class MenuWorkbenchToolBar extends WorkbenchToolBar {
336336

337337
private readonly _onDidChangeMenuItems = this._store.add(new Emitter<this>());
338-
readonly onDidChangeMenuItems: Event<this> = this._onDidChangeMenuItems.event;
338+
get onDidChangeMenuItems() { return this._onDidChangeMenuItems.event; }
339339

340340
constructor(
341341
container: HTMLElement,

0 commit comments

Comments
 (0)