Allow slash commands to opt into auto-executing (microsoft#188097)

* Allow slash commands to opt into auto-executing

* Allow inline chat slash commands to opt into auto-executing

* `hasArgs` -> `executeImmediately`

* Check for one line of text

* Use completion commands

* One more `executeImmediately` rename

* Reuse existing inline and panel chat actions

Author: joyceerhl

src/vs/workbench/api/common/extHostInlineChat.ts

@@ -123,7 +123,7 @@ export class ExtHostInteractiveEditor implements ExtHostInlineChatShape {
 		return {
 			id,
 			placeholder: session.placeholder,
-			slashCommands: session.slashCommands?.map(c => ({ command: c.command, detail: c.detail, refer: c.refer })),
+			slashCommands: session.slashCommands?.map(c => ({ command: c.command, detail: c.detail, refer: c.refer, executeImmediately: c.executeImmediately })),
 			wholeRange: typeConvert.Range.from(session.wholeRange),
 			message: session.message
 		};

src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts

@@ -20,38 +20,42 @@ function isExecuteActionContext(thing: unknown): thing is IChatExecuteActionCont
 	return typeof thing === 'object' && thing !== null && 'widget' in thing;
 }
 
-export function registerChatExecuteActions() {
-	registerAction2(class SubmitAction extends Action2 {
-		constructor() {
-			super({
-				id: 'workbench.action.chat.submit',
-				title: {
-					value: localize('interactive.submit.label', "Submit"),
-					original: 'Submit'
-				},
-				f1: false,
-				category: CHAT_CATEGORY,
-				icon: Codicon.send,
-				precondition: CONTEXT_CHAT_INPUT_HAS_TEXT,
-				menu: {
-					id: MenuId.ChatExecute,
-					when: CONTEXT_CHAT_REQUEST_IN_PROGRESS.negate(),
-					group: 'navigation',
-				}
-			});
-		}
+export class SubmitAction extends Action2 {
+	static readonly ID = 'workbench.action.chat.submit';
 
-		run(accessor: ServicesAccessor, ...args: any[]) {
-			const context = args[0];
-			if (!isExecuteActionContext(context)) {
-				return;
+	constructor() {
+		super({
+			id: SubmitAction.ID,
+			title: {
+				value: localize('interactive.submit.label', "Submit"),
+				original: 'Submit'
+			},
+			f1: false,
+			category: CHAT_CATEGORY,
+			icon: Codicon.send,
+			precondition: CONTEXT_CHAT_INPUT_HAS_TEXT,
+			menu: {
+				id: MenuId.ChatExecute,
+				when: CONTEXT_CHAT_REQUEST_IN_PROGRESS.negate(),
+				group: 'navigation',
 			}
+		});
+	}
 
-			context.widget.acceptInput();
+	run(accessor: ServicesAccessor, ...args: any[]) {
+		const context = args[0];
+		if (!isExecuteActionContext(context)) {
+			return;
 		}
-	});
 
-	registerAction2(class SubmitAction extends Action2 {
+		context.widget.acceptInput();
+	}
+}
+
+export function registerChatExecuteActions() {
+	registerAction2(SubmitAction);
+
+	registerAction2(class CancelAction extends Action2 {
 		constructor() {
 			super({
 				id: 'workbench.action.chat.cancel',

src/vs/workbench/contrib/chat/browser/chatWidget.ts

@@ -238,6 +238,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
 					command: 'clear',
 					sortText: 'z_clear',
 					detail: localize('clear', "Clear the session"),
+					executeImmediately: true
 				};
 				this.lastSlashCommands = [
 					...(commands ?? []),

src/vs/workbench/contrib/chat/browser/contrib/chatInputEditorContrib.ts

@@ -23,6 +23,7 @@ import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle
 import { ChatInputPart } from 'vs/workbench/contrib/chat/browser/chatInputPart';
 import { IChatService } from 'vs/workbench/contrib/chat/common/chatService';
 import { SlashCommandContentWidget } from 'vs/workbench/contrib/chat/browser/chatSlashCommandContentWidget';
+import { SubmitAction } from 'vs/workbench/contrib/chat/browser/actions/chatExecuteActions';
 
 const decorationDescription = 'chat';
 const slashCommandPlaceholderDecorationType = 'chat-session-detail';
@@ -165,7 +166,7 @@ class InputEditorDecorations extends Disposable {
 	}
 }
 
-class InputEditorSlashCommandFollowups extends Disposable {
+class InputEditorSlashCommandMode extends Disposable {
 	constructor(
 		private readonly widget: IChatWidget,
 		@IChatService private readonly chatService: IChatService
@@ -194,7 +195,7 @@ class InputEditorSlashCommandFollowups extends Disposable {
 	}
 }
 
-ChatWidget.CONTRIBS.push(InputEditorDecorations, InputEditorSlashCommandFollowups);
+ChatWidget.CONTRIBS.push(InputEditorDecorations, InputEditorSlashCommandMode);
 
 class SlashCommandCompletions extends Disposable {
 	constructor(
@@ -230,7 +231,8 @@ class SlashCommandCompletions extends Disposable {
 							detail: c.detail,
 							range: new Range(1, 1, 1, 1),
 							sortText: c.sortText ?? c.command,
-							kind: CompletionItemKind.Text // The icons are disabled here anyway
+							kind: CompletionItemKind.Text, // The icons are disabled here anyway,
+							command: c.executeImmediately ? { id: SubmitAction.ID, title: withSlash, arguments: [{ widget }] } : undefined,
 						};
 					})
 				};

src/vs/workbench/contrib/chat/common/chatService.ts

@@ -67,10 +67,26 @@ export interface ISlashCommandProvider {
 
 export interface ISlashCommand {
 	command: string;
-	shouldRepopulate?: boolean;
 	provider?: ISlashCommandProvider;
 	sortText?: string;
 	detail?: string;
+
+	/**
+	 * Whether the command should execute as soon
+	 * as it is entered. Defaults to `false`.
+	 */
+	executeImmediately?: boolean;
+	/**
+	 * Whether executing the command puts the
+	 * chat into a persistent mode, where the
+	 * slash command is prepended to the chat input.
+	 */
+	shouldRepopulate?: boolean;
+	/**
+	 * Placeholder text to render in the chat input
+	 * when the slash command has been repopulated.
+	 * Has no effect if `shouldRepopulate` is `false`.
+	 */
 	followupPlaceholder?: string;
 }
 

src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts

@@ -670,6 +670,7 @@ export class InlineChatWidget {
 						insertTextRules: CompletionItemInsertTextRule.InsertAsSnippet,
 						kind: CompletionItemKind.Text,
 						range: new Range(1, 1, 1, 1),
+						command: command.executeImmediately ? { id: 'inlineChat.accept', title: withSlash } : undefined
 					};
 				});
 

src/vs/workbench/contrib/inlineChat/common/inlineChat.ts

@@ -24,6 +24,7 @@ export interface IInlineChatSlashCommand {
 	command: string;
 	detail?: string;
 	refer?: boolean;
+	executeImmediately?: boolean;
 }
 
 export interface IInlineChatSession {

src/vscode-dts/vscode.proposed.interactive.d.ts

@@ -9,6 +9,11 @@ declare module 'vscode' {
 		command: string;
 		detail?: string;
 		refer?: boolean;
+		/**
+		 * Whether the command should execute as soon
+		 * as it is entered. Defaults to `false`.
+		 */
+		executeImmediately?: boolean;
 		// kind: CompletionItemKind;
 	}
 
@@ -130,10 +135,11 @@ declare module 'vscode' {
 
 	export interface InteractiveSessionSlashCommand {
 		command: string;
-		shouldRepopulate?: boolean;
 		kind: CompletionItemKind;
 		detail?: string;
+		shouldRepopulate?: boolean;
 		followupPlaceholder?: string;
+		executeImmediately?: boolean;
 	}
 
 	export interface InteractiveSessionReplyFollowup {