Simplify empty check, fix test assertions

Author: Tyriar

src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/executeStrategy.ts

@@ -56,14 +56,10 @@ export interface IPromptDetectionResult {
  * time to complete before assuming they're done.
  */
 export function detectsCommonPromptPattern(cursorLine: string): IPromptDetectionResult {
-	if (!cursorLine || cursorLine.trim().length === 0) {
+	if (cursorLine.trim().length === 0) {
 		return { detected: false, reason: 'Content is empty or contains only whitespace' };
 	}
 
-	if (!cursorLine) {
-		return { detected: false, reason: 'No non-empty lines found' };
-	}
-
 	// PowerShell prompt: PS C:\> or similar patterns
 	if (/PS\s+[A-Z]:\\.*>\s*$/.test(cursorLine)) {
 		return { detected: true, reason: `PowerShell prompt pattern detected: "${cursorLine}"` };

src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/executeStrategy.test.ts

@@ -11,61 +11,61 @@ suite('Execute Strategy - Prompt Detection', () => {
 	ensureNoDisposablesAreLeakedInTestSuite();
 
 	test('detectsCommonPromptPattern should detect PowerShell prompts', () => {
-		strictEqual(detectsCommonPromptPattern('PS C:\\>'), true);
-		strictEqual(detectsCommonPromptPattern('PS C:\\Windows\\System32>'), true);
-		strictEqual(detectsCommonPromptPattern('PS C:\\Users\\test> '), true);
+		strictEqual(detectsCommonPromptPattern('PS C:\\>').detected, true);
+		strictEqual(detectsCommonPromptPattern('PS C:\\Windows\\System32>').detected, true);
+		strictEqual(detectsCommonPromptPattern('PS C:\\Users\\test> ').detected, true);
 	});
 
 	test('detectsCommonPromptPattern should detect Command Prompt', () => {
-		strictEqual(detectsCommonPromptPattern('C:\\>'), true);
-		strictEqual(detectsCommonPromptPattern('C:\\Windows\\System32>'), true);
-		strictEqual(detectsCommonPromptPattern('D:\\test> '), true);
+		strictEqual(detectsCommonPromptPattern('C:\\>').detected, true);
+		strictEqual(detectsCommonPromptPattern('C:\\Windows\\System32>').detected, true);
+		strictEqual(detectsCommonPromptPattern('D:\\test> ').detected, true);
 	});
 
 	test('detectsCommonPromptPattern should detect Bash prompts', () => {
-		strictEqual(detectsCommonPromptPattern('user@host:~$ '), true);
-		strictEqual(detectsCommonPromptPattern('$ '), true);
-		strictEqual(detectsCommonPromptPattern('[user@host ~]$ '), true);
+		strictEqual(detectsCommonPromptPattern('user@host:~$ ').detected, true);
+		strictEqual(detectsCommonPromptPattern('$ ').detected, true);
+		strictEqual(detectsCommonPromptPattern('[user@host ~]$ ').detected, true);
 	});
 
 	test('detectsCommonPromptPattern should detect root prompts', () => {
-		strictEqual(detectsCommonPromptPattern('root@host:~# '), true);
-		strictEqual(detectsCommonPromptPattern('# '), true);
-		strictEqual(detectsCommonPromptPattern('[root@host ~]# '), true);
+		strictEqual(detectsCommonPromptPattern('root@host:~# ').detected, true);
+		strictEqual(detectsCommonPromptPattern('# ').detected, true);
+		strictEqual(detectsCommonPromptPattern('[root@host ~]# ').detected, true);
 	});
 
 	test('detectsCommonPromptPattern should detect Python REPL', () => {
-		strictEqual(detectsCommonPromptPattern('>>> '), true);
-		strictEqual(detectsCommonPromptPattern('>>>'), true);
+		strictEqual(detectsCommonPromptPattern('>>> ').detected, true);
+		strictEqual(detectsCommonPromptPattern('>>>').detected, true);
 	});
 
 	test('detectsCommonPromptPattern should detect starship prompts', () => {
-		strictEqual(detectsCommonPromptPattern('~ ❯ '), true);
-		strictEqual(detectsCommonPromptPattern('/path/to/project ❯'), true);
+		strictEqual(detectsCommonPromptPattern('~ \u276f ').detected, true);
+		strictEqual(detectsCommonPromptPattern('/path/to/project \u276f').detected, true);
 	});
 
 	test('detectsCommonPromptPattern should detect generic prompts', () => {
-		strictEqual(detectsCommonPromptPattern('test> '), true);
-		strictEqual(detectsCommonPromptPattern('someprompt% '), true);
+		strictEqual(detectsCommonPromptPattern('test> ').detected, true);
+		strictEqual(detectsCommonPromptPattern('someprompt% ').detected, true);
 	});
 
 	test('detectsCommonPromptPattern should handle multiline content', () => {
 		const multilineContent = `command output line 1
 command output line 2
 user@host:~$ `;
-		strictEqual(detectsCommonPromptPattern(multilineContent), true);
+		strictEqual(detectsCommonPromptPattern(multilineContent).detected, true);
 	});
 
 	test('detectsCommonPromptPattern should reject non-prompt content', () => {
-		strictEqual(detectsCommonPromptPattern('just some output'), false);
-		strictEqual(detectsCommonPromptPattern('error: command not found'), false);
-		strictEqual(detectsCommonPromptPattern(''), false);
-		strictEqual(detectsCommonPromptPattern('   '), false);
+		strictEqual(detectsCommonPromptPattern('just some output').detected, false);
+		strictEqual(detectsCommonPromptPattern('error: command not found').detected, false);
+		strictEqual(detectsCommonPromptPattern('').detected, false);
+		strictEqual(detectsCommonPromptPattern('   ').detected, false);
 	});
 
 	test('detectsCommonPromptPattern should handle edge cases', () => {
-		strictEqual(detectsCommonPromptPattern('output\n\n\n'), false);
-		strictEqual(detectsCommonPromptPattern('\n\n$ \n\n'), true); // prompt with surrounding whitespace
-		strictEqual(detectsCommonPromptPattern('output\nPS C:\\> '), true); // prompt at end after output
+		strictEqual(detectsCommonPromptPattern('output\n\n\n').detected, false);
+		strictEqual(detectsCommonPromptPattern('\n\n$ \n\n').detected, true); // prompt with surrounding whitespace
+		strictEqual(detectsCommonPromptPattern('output\nPS C:\\> ').detected, true); // prompt at end after output
 	});
-});
+});