Skip to content

Commit 06fb8fd

Browse files
authored
Don't change editor selection if invoked for line containing selection (microsoft#178083)
1 parent 324d1a2 commit 06fb8fd

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/vs/workbench/contrib/codeEditor/browser/editorLineNumberMenu.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,15 @@ export class EditorLineNumberContextMenu extends Disposable implements IEditorCo
9999
// set the selection to the clicked line number
100100
if (e.target.type === MouseTargetType.GUTTER_LINE_NUMBERS) {
101101
const currentSelections = this.editor.getSelections();
102-
const containsSelection = currentSelections?.some(selection => selection.containsPosition({ lineNumber, column: 1 }));
102+
const lineRange = {
103+
startLineNumber: lineNumber,
104+
endLineNumber: lineNumber,
105+
startColumn: 1,
106+
endColumn: model.getLineLength(lineNumber) + 1
107+
};
108+
const containsSelection = currentSelections?.some(selection => !selection.isEmpty() && selection.intersectRanges(lineRange) !== null);
103109
if (!containsSelection) {
104-
const selection = {
105-
startLineNumber: lineNumber,
106-
endLineNumber: lineNumber,
107-
startColumn: 1,
108-
endColumn: model.getLineLength(lineNumber) + 1
109-
};
110-
this.editor.setSelection(selection, TextEditorSelectionSource.PROGRAMMATIC);
110+
this.editor.setSelection(lineRange, TextEditorSelectionSource.PROGRAMMATIC);
111111
}
112112
}
113113

0 commit comments

Comments
 (0)