debt - some node.js module import 💄 (microsoft#264158)

Author: bpasero

src/bootstrap-esm.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import * as fs from 'fs';
+import * as fs from 'node:fs';
 import { register } from 'node:module';
 import { product, pkg } from './bootstrap-meta.js';
 import './bootstrap-node.js';

src/bootstrap-node.ts

@@ -3,8 +3,8 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import * as path from 'path';
-import * as fs from 'fs';
+import * as path from 'node:path';
+import * as fs from 'node:fs';
 import { createRequire } from 'node:module';
 import type { IProductConfiguration } from './vs/base/common/product.js';
 

src/main.ts

@@ -3,10 +3,10 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import * as path from 'path';
+import * as path from 'node:path';
 import * as fs from 'original-fs';
-import * as os from 'os';
-import { performance } from 'perf_hooks';
+import * as os from 'node:os';
+import { performance } from 'node:perf_hooks';
 import { configurePortable } from './bootstrap-node.js';
 import { bootstrapESM } from './bootstrap-esm.js';
 import { app, protocol, crashReporter, Menu, contentTracing } from 'electron';

src/server-cli.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import './bootstrap-server.js'; // this MUST come before other imports as it changes global state
-import { join } from 'path';
+import { join } from 'node:path';
 import { devInjectNodeModuleLookupPath } from './bootstrap-node.js';
 import { bootstrapESM } from './bootstrap-esm.js';
 import { resolveNLSConfiguration } from './vs/base/node/nls.js';

src/server-main.ts

@@ -4,12 +4,12 @@
  *--------------------------------------------------------------------------------------------*/
 
 import './bootstrap-server.js'; // this MUST come before other imports as it changes global state
-import * as path from 'path';
-import * as http from 'http';
-import { AddressInfo } from 'net';
-import * as os from 'os';
-import * as readline from 'readline';
-import { performance } from 'perf_hooks';
+import * as path from 'node:path';
+import * as http from 'node:http';
+import type { AddressInfo } from 'node:net';
+import * as os from 'node:os';
+import * as readline from 'node:readline';
+import { performance } from 'node:perf_hooks';
 import minimist from 'minimist';
 import { devInjectNodeModuleLookupPath, removeGlobalNodeJsModuleLookupPaths } from './bootstrap-node.js';
 import { bootstrapESM } from './bootstrap-esm.js';

src/vs/platform/debug/electron-main/extensionHostDebugIpc.ts

@@ -71,7 +71,7 @@ export class ElectronExtensionHostDebugBroadcastChannel<TContext> extends Extens
 	}
 
 	private async openCdpServer(ident: string, onSocket: (socket: ISocket) => void) {
-		const { createServer } = await import('http'); // Lazy due to https://github.com/microsoft/vscode/issues/263533
+		const { createServer } = await import('http'); // Lazy due to https://github.com/nodejs/node/issues/59686
 		const server = createServer((req, res) => {
 			res.statusCode = 404;
 			res.end();

src/vs/platform/telemetry/node/1dsAppender.ts

@@ -8,7 +8,6 @@ import { streamToBuffer } from '../../../base/common/buffer.js';
 import { CancellationToken } from '../../../base/common/cancellation.js';
 import { IRequestOptions } from '../../../base/parts/request/common/request.js';
 import { IRequestService } from '../../request/common/request.js';
-import * as https from 'https';
 import { AbstractOneDataSystemAppender, IAppInsightsCore } from '../common/1dsAppender.js';
 
 type OnCompleteFunc = (status: number, headers: { [headerName: string]: string }, response?: string) => void;
@@ -43,6 +42,7 @@ async function makeTelemetryRequest(options: IRequestOptions, requestService: IR
  * @returns An object containing the headers, statusCode, and responseData
  */
 async function makeLegacyTelemetryRequest(options: IRequestOptions): Promise<IResponseData> {
+	const https = await import('https'); // Lazy due to https://github.com/nodejs/node/issues/59686
 	const httpsOptions = {
 		method: options.type,
 		headers: options.headers