Add isSticky to chat agent (microsoft#205322)

Author: roblourens

src/vs/workbench/api/common/extHostChatAgents2.ts

@@ -353,6 +353,7 @@ class ExtHostChatAgent {
 	private _supportIssueReporting: boolean | undefined;
 	private _agentVariableProvider?: { provider: vscode.ChatAgentCompletionItemProvider; triggerCharacters: string[] };
 	private _welcomeMessageProvider?: vscode.ChatAgentWelcomeMessageProvider | undefined;
+	private _isSticky: boolean | undefined;
 
 	constructor(
 		public readonly extension: IExtensionDescription,
@@ -476,7 +477,8 @@ class ExtHostChatAgent {
 					helpTextPrefix: (!this._helpTextPrefix || typeof this._helpTextPrefix === 'string') ? this._helpTextPrefix : typeConvert.MarkdownString.from(this._helpTextPrefix),
 					helpTextPostfix: (!this._helpTextPostfix || typeof this._helpTextPostfix === 'string') ? this._helpTextPostfix : typeConvert.MarkdownString.from(this._helpTextPostfix),
 					sampleRequest: this._sampleRequest,
-					supportIssueReporting: this._supportIssueReporting
+					supportIssueReporting: this._supportIssueReporting,
+					isSticky: this._isSticky,
 				});
 				updateScheduled = false;
 			});
@@ -622,6 +624,13 @@ class ExtHostChatAgent {
 				? undefined!
 				: this._onDidPerformAction.event
 			,
+			get isSticky() {
+				return that._isSticky;
+			},
+			set isSticky(v) {
+				that._isSticky = v;
+				updateMetadataSoon();
+			},
 			dispose() {
 				disposed = true;
 				that._commandProvider = undefined;

src/vs/workbench/contrib/chat/browser/contrib/chatInputEditorContrib.ts

@@ -237,8 +237,7 @@ class InputEditorSlashCommandMode extends Disposable {
 	public readonly id = 'InputEditorSlashCommandMode';
 
 	constructor(
-		private readonly widget: IChatWidget,
-		@IChatAgentService private readonly _chatAgentService: IChatAgentService
+		private readonly widget: IChatWidget
 	) {
 		super();
 		this._register(this.widget.onDidSubmitAgent(e => {
@@ -248,10 +247,9 @@ class InputEditorSlashCommandMode extends Disposable {
 
 	private async repopulateAgentCommand(agent: IChatAgentData, slashCommand: IChatAgentCommand | undefined) {
 		let value: string | undefined;
-		if (slashCommand && slashCommand.shouldRepopulate) {
+		if (slashCommand && slashCommand.isSticky) {
 			value = `${chatAgentLeader}${agent.id} ${chatSubcommandLeader}${slashCommand.name} `;
-		} else if (agent.id !== this._chatAgentService.getDefaultAgent()?.id) {
-			// Agents always repopulate, and slash commands fall back to the agent if they don't repopulate
+		} else if (agent.metadata.isSticky) {
 			value = `${chatAgentLeader}${agent.id} `;
 		}
 

src/vs/workbench/contrib/chat/common/chatAgents.ts

@@ -54,7 +54,7 @@ export interface IChatAgentCommand {
 	 * chat into a persistent mode, where the
 	 * slash command is prepended to the chat input.
 	 */
-	shouldRepopulate?: boolean;
+	isSticky?: boolean;
 
 	/**
 	 * Placeholder text to render in the chat input
@@ -79,6 +79,7 @@ export interface IChatAgentMetadata {
 	sampleRequest?: string;
 	supportIssueReporting?: boolean;
 	followupPlaceholder?: string;
+	isSticky?: boolean;
 }
 
 

src/vscode-dts/vscode.proposed.chatAgents2.d.ts

@@ -277,6 +277,11 @@ declare module 'vscode' {
 		 */
 		sampleRequest?: string;
 
+		/**
+		 * Whether invoking the agent puts the chat into a persistent mode, where the agent is automatically added to the chat input for the next message.
+		 */
+		isSticky?: boolean;
+
 		/**
 		 * An event that fires whenever feedback for a result is received, e.g. when a user up- or down-votes
 		 * a result.