Merge pull request #209 from gitpod-io/aledbf/package-build

Fix display of build errors

Author: aledbf

pkg/leeway/reporter.go

@@ -215,13 +215,15 @@ func (r *ConsoleReporter) PackageBuildFinished(pkg *Package, rep *PackageBuildRe
 	delete(r.times, nme)
 	r.mu.Unlock()
 
-	var coverage string
-	if rep.TestCoverageAvailable {
-		coverage = color.Sprintf("<fg=yellow>test coverage: %d%%</> <gray>(%d of %d functions have tests)</>\n", rep.TestCoveragePercentage, rep.FunctionsWithTest, rep.FunctionsWithTest+rep.FunctionsWithoutTest)
-	}
-	msg := color.Sprintf("%s<green>package build succeded</> <gray>(%.2fs)</>\n", coverage, dur.Seconds())
+	var msg string
 	if rep.Error != nil {
 		msg = color.Sprintf("<red>package build failed while %sing</>\n<white>Reason:</> %s\n", rep.LastPhase(), rep.Error)
+	} else {
+		var coverage string
+		if rep.TestCoverageAvailable {
+			coverage = color.Sprintf("<fg=yellow>test coverage: %d%%</> <gray>(%d of %d functions have tests)</>\n", rep.TestCoveragePercentage, rep.FunctionsWithTest, rep.FunctionsWithTest+rep.FunctionsWithoutTest)
+		}
+		msg = color.Sprintf("%s<green>package build succeded</> <gray>(%.2fs)</>\n", coverage, dur.Seconds())
 	}
 	//nolint:errcheck
 	io.WriteString(out, msg)
@@ -438,7 +440,7 @@ func (r *HTMLReporter) Report() {
 {{- range $pkg, $report := .Packages }}
 <h2 id="{{ $report.ID }}">{{ $report.StatusIcon }} {{ $pkg }}</h2>
 {{ if $report.HasError -}}
-<details open> 
+<details open>
 	<summary>Error message</summary>
 	<pre><code>{{ $report.Error }}</code></pre>
 </details>