Fix the error of the deactivation (#245)

* Fix the bug by the nested error

* Fix the bug from the constraint validation

Author: Noah Hanjun Lee

internal/pkg/store/repo.go

@@ -220,11 +220,12 @@ func (s *Store) Activate(ctx context.Context, r *ent.Repo) (*ent.Repo, error) {
 }
 
 func (s *Store) Deactivate(ctx context.Context, r *ent.Repo) (*ent.Repo, error) {
+	// NOTE: Do not set the 'owner_id' zero value.
+	// It could make the constraint error.
 	ret, err := s.c.Repo.
 		UpdateOne(r).
 		SetActive(false).
 		SetWebhookID(0).
-		SetOwnerID(0).
 		Save(ctx)
 	if ent.IsValidationError(err) {
 		return nil, e.NewErrorWithMessage(

internal/server/global/helper.go

@@ -6,14 +6,11 @@ import (
 	"github.com/gitploy-io/gitploy/pkg/e"
 )
 
+// GetZapLogLevel return the warning level if the error is managed in the system.
 func GetZapLogLevel(err error) zapcore.Level {
 	if !e.IsError(err) {
 		return zapcore.ErrorLevel
 	}
 
-	if err.(*e.Error).Code == e.ErrorCodeInternalError {
-		return zapcore.ErrorLevel
-	}
-
 	return zapcore.WarnLevel
 }

pkg/e/code_test.go

@@ -1,6 +1,9 @@
 package e
 
-import "testing"
+import (
+	"fmt"
+	"testing"
+)
 
 func Test_IsError(t *testing.T) {
 	t.Run("Return true when the type of error is Error.", func(t *testing.T) {
@@ -9,6 +12,13 @@ func Test_IsError(t *testing.T) {
 			t.Fatalf("IsError = %v, wanted %v", ok, true)
 		}
 	})
+
+	t.Run("Return false when the type of error is not Error.", func(t *testing.T) {
+		err := fmt.Errorf("fmt.Error")
+		if ok := IsError(err); ok {
+			t.Fatalf("IsError = %v, wanted %v", ok, false)
+		}
+	})
 }
 
 func Test_HasErrorCode(t *testing.T) {