Skip to content

Commit f6847f2

Browse files
authored
fix argocd application namespace (#23)
Signed-off-by: Carlos Santana <csantana23@gmail.com>
1 parent bfa4233 commit f6847f2

File tree

10 files changed

+20
-36
lines changed

10 files changed

+20
-36
lines changed
File renamed without changes.

argocd/iac/terraform/examples/eks/ingress-alb/main.tf renamed to argocd/iac/terraform/examples/eks/argocd-ingress/main.tf

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,18 +80,20 @@ locals {
8080
#enable_aws_gateway_api_controller = true
8181
#enable_aws_ebs_csi_resources = true # generate gp2 and gp3 storage classes for ebs-csi
8282
#enable_aws_secrets_store_csi_driver_provider = true
83+
enable_aws_argocd_ingress = true
8384
}
8485
oss_addons = {
86+
enable_argocd = false
8587
#enable_argo_rollouts = true
86-
#enable_argo_events = true
88+
#enable_argo_events = true
8789
#enable_argo_workflows = true
8890
#enable_cluster_proportional_autoscaler = true
8991
#enable_gatekeeper = true
9092
#enable_gpu_operator = true
9193
#enable_ingress_nginx = true
9294
#enable_kyverno = true
9395
#enable_kube_prometheus_stack = true
94-
enable_metrics_server = true
96+
#enable_metrics_server = true
9597
#enable_prometheus_adapter = true
9698
#enable_secrets_store_csi_driver = true
9799
#enable_vpa = true

argocd/iac/terraform/examples/eks/ingress-alb/outputs.tf renamed to argocd/iac/terraform/examples/eks/argocd-ingress/outputs.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ output "configure_argocd" {
1616
argocd login --port-forward --username admin --password $(argocd admin initial-password | head -1)
1717
echo "ArgoCD Username: admin"
1818
echo "ArgoCD Password: $(kubectl get secrets argocd-initial-admin-secret -n argocd --template="{{index .data.password | base64decode}}")"
19+
echo Port Forward: http://localhost:8080
1920
kubectl port-forward -n argocd svc/argo-cd-argocd-server 8080:80
2021
EOT
2122
}

argocd/iac/terraform/examples/eks/multi-cluster/hub-spoke-shared/hub/main.tf

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ locals {
5353
gitops_addons_path = var.gitops_addons_path
5454
gitops_addons_revision = var.gitops_addons_revision
5555

56+
argocd_namespace = "argocd"
57+
5658
aws_addons = {
5759
enable_cert_manager = true
5860
#enable_aws_efs_csi_driver = true
@@ -62,7 +64,7 @@ locals {
6264
#enable_cluster_autoscaler = true
6365
#enable_external_dns = true
6466
#enable_external_secrets = true
65-
enable_aws_load_balancer_controller = true
67+
#enable_aws_load_balancer_controller = true
6668
#enable_fargate_fluentbit = true
6769
#enable_aws_for_fluentbit = true
6870
#enable_aws_node_termination_handler = true
@@ -84,7 +86,7 @@ locals {
8486
#enable_ingress_nginx = true
8587
#enable_kyverno = true
8688
#enable_kube_prometheus_stack = true
87-
enable_metrics_server = true
89+
#enable_metrics_server = true
8890
#enable_prometheus_adapter = true
8991
#enable_secrets_store_csi_driver = true
9092
#enable_vpa = true
@@ -101,8 +103,8 @@ locals {
101103
aws_vpc_id = module.vpc.vpc_id
102104
},
103105
{
104-
argocd_iam_role_arn = module.argocd_irsa.iam_role_arn,
105-
argocd_namespace = "argocd"
106+
argocd_iam_role_arn = module.argocd_irsa.iam_role_arn
107+
argocd_namespace = local.argocd_namespace
106108
},
107109
{
108110
addons_repo_url = local.gitops_addons_url
@@ -145,18 +147,7 @@ module "gitops_bridge_bootstrap" {
145147
argocd_cluster = module.gitops_bridge_metadata.argocd
146148
argocd_bootstrap_app_of_apps = local.argocd_bootstrap_app_of_apps
147149
argocd = {
148-
values = [
149-
<<-EOT
150-
controller:
151-
serviceAccount:
152-
annotations:
153-
eks.amazonaws.com/role-arn: ${module.argocd_irsa.iam_role_arn}
154-
server:
155-
serviceAccount:
156-
annotations:
157-
eks.amazonaws.com/role-arn: ${module.argocd_irsa.iam_role_arn}
158-
EOT
159-
]
150+
namespace = local.argocd_namespace
160151
}
161152
}
162153

@@ -178,7 +169,7 @@ module "argocd_irsa" {
178169
oidc_providers = {
179170
this = {
180171
provider_arn = module.eks.oidc_provider_arn
181-
namespace = "argocd"
172+
namespace = local.argocd_namespace
182173
service_account = "argocd-*"
183174
}
184175
}

argocd/iac/terraform/examples/eks/multi-cluster/hub-spoke/hub/main.tf

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ locals {
5353
gitops_addons_path = var.gitops_addons_path
5454
gitops_addons_revision = var.gitops_addons_revision
5555

56+
argocd_namespace = "argocd"
57+
5658
aws_addons = {
5759
enable_cert_manager = true
5860
#enable_aws_efs_csi_driver = true
@@ -84,7 +86,7 @@ locals {
8486
#enable_ingress_nginx = true
8587
#enable_kyverno = true
8688
#enable_kube_prometheus_stack = true
87-
enable_metrics_server = true
89+
#enable_metrics_server = true
8890
#enable_prometheus_adapter = true
8991
#enable_secrets_store_csi_driver = true
9092
#enable_vpa = true
@@ -101,8 +103,8 @@ locals {
101103
aws_vpc_id = module.vpc.vpc_id
102104
},
103105
{
104-
argocd_iam_role_arn = module.argocd_irsa.iam_role_arn,
105-
argocd_namespace = "argocd"
106+
argocd_iam_role_arn = module.argocd_irsa.iam_role_arn
107+
argocd_namespace = local.argocd_namespace
106108
},
107109
{
108110
addons_repo_url = local.gitops_addons_url
@@ -145,18 +147,7 @@ module "gitops_bridge_bootstrap" {
145147
argocd_cluster = module.gitops_bridge_metadata.argocd
146148
argocd_bootstrap_app_of_apps = local.argocd_bootstrap_app_of_apps
147149
argocd = {
148-
values = [
149-
<<-EOT
150-
controller:
151-
serviceAccount:
152-
annotations:
153-
eks.amazonaws.com/role-arn: ${module.argocd_irsa.iam_role_arn}
154-
server:
155-
serviceAccount:
156-
annotations:
157-
eks.amazonaws.com/role-arn: ${module.argocd_irsa.iam_role_arn}
158-
EOT
159-
]
150+
namespace = local.argocd_namespace
160151
}
161152
}
162153

@@ -178,7 +169,7 @@ module "argocd_irsa" {
178169
oidc_providers = {
179170
this = {
180171
provider_arn = module.eks.oidc_provider_arn
181-
namespace = "argocd"
172+
namespace = local.argocd_namespace
182173
service_account = "argocd-*"
183174
}
184175
}
@@ -201,7 +192,6 @@ data "aws_iam_policy_document" "irsa_policy" {
201192
}
202193
}
203194

204-
205195
################################################################################
206196
# EKS Blueprints Addons
207197
################################################################################

0 commit comments

Comments
 (0)