show an error message if user.name or user.email is unset

Author: spderosso

gitless/cli/gl_commit.py

@@ -54,13 +54,7 @@ def main(args, repo):
   if args.p:
     partials = _do_partial_selection(commit_files, curr_b)
 
-  if not repo.config['user.name']:
-    pprint.err('Missing name for commit author')
-    pprint.err_exp('change the value of git\'s user.name setting')
-    return False
-  if not repo.config['user.email']:
-    pprint.err('Missing email for commit author')
-    pprint.err_exp('change the value of git\'s user.email setting')
+  if not _author_info_is_ok(repo):
     return False
 
   msg = args.m if args.m else commit_dialog.show(commit_files, repo)
@@ -84,6 +78,24 @@ def main(args, repo):
   return True
 
 
+def _author_info_is_ok(repo):
+  def show_config_error(key):
+    pprint.err('Missing {0} for commit author'.format(key))
+    pprint.err_exp('change the value of git\'s user.{0} setting'.format(key))
+
+  def config_is_ok(key):
+    try:
+      if not repo.config['user.{0}'.format(key)]:
+        show_config_error(key)
+        return False
+    except KeyError:
+      show_config_error(key)
+      return False
+    return True
+
+  return config_is_ok('name') and config_is_ok('email')
+
+
 def _do_partial_selection(files, curr_b):
   partials = []
   for fp in files: