Merge pull request #654 from esep/prevent_nsee

Prevent NoSuchElementException from PagerSpliterator class

Author: jabby

src/main/java/org/gitlab4j/api/PagerSpliterator.java

@@ -30,8 +30,10 @@ public boolean tryAdvance(Consumer<? super T> action) {
 			return true;
 		} else if (pager.hasNext()) {
 			elements = pager.next().iterator();
-			action.accept(elements.next());
-			return true;
+			if(elements.hasNext()) {
+				action.accept(elements.next());
+				return true;
+			}
 		}
 		return false;
 	}

src/test/java/org/gitlab4j/api/PagerSpliteratorTest.java

@@ -46,6 +46,16 @@ public void shouldDoNotFailOnEmptySource() {
 
 		assertFalse(success);
 	}
+	
+	@Test
+	public void shouldReturnFalseIfNextPagerItemMissing() {
+		when(pager.hasNext()).thenReturn(true);
+		when(pager.next()).thenReturn(Collections.emptyList());
+
+		boolean success = pagerSpliterator.tryAdvance(System.out::println);
+
+		assertFalse(success);
+	}
 
 	@Test
 	public void shouldThrowNullPointerExceptionWhenActionIsMissing() {
@@ -75,4 +85,4 @@ public void shouldAllowToGatherDataPageByPage() {
 
 		assertArrayEquals(new Integer[]{1, 2, 3, 4, 5}, elements);
 	}
-}
+}