Fixes useless spread lint issues

Author: eamodio

scripts/prep-release.js

@@ -46,7 +46,7 @@ rl.question(`Enter the new version number (format x.x.x, current is ${currentVer
 	// Add the new version header below the ## [Unreleased] header
 	data = data.replace('## [Unreleased]', newVersionHeader);
 
-	const unreleasedLink = match[0].replace(/\/compare\/v(.+?)\.\.\.HEAD/, `\/compare\/v${version}...HEAD`);
+	const unreleasedLink = match[0].replace(/\/compare\/v(.+?)\.\.\.HEAD/, `/compare/v${version}...HEAD`);
 
 	// Update the [unreleased]: line
 	data = data.replace(match[0], `${unreleasedLink}\n${newVersionLink}`);

src/commands/quickCommand.steps.ts

@@ -228,8 +228,8 @@ export async function getWorktrees(
 	},
 ): Promise<WorktreeQuickPickItem[]> {
 	const worktrees = repoOrWorktrees instanceof Repository ? await repoOrWorktrees.getWorktrees() : repoOrWorktrees;
-	return Promise.all<WorktreeQuickPickItem>([
-		...worktrees
+	return Promise.all<WorktreeQuickPickItem>(
+		worktrees
 			.filter(w => filter == null || filter(w))
 			.map(async w => {
 				let missing = false;
@@ -254,7 +254,7 @@ export async function getWorktrees(
 					},
 				);
 			}),
-	]);
+	);
 }
 
 export async function getBranchesAndOrTags(

src/commands/quickCommand.ts

@@ -334,7 +334,7 @@ export function createConfirmStep<T extends QuickPickItem, Context extends { tit
 		ignoreFocusOut: true,
 		items: [...confirmations, cancel ?? createDirectiveQuickPickItem(Directive.Cancel)],
 		selectedItems: [confirmations.find(c => c.picked) ?? confirmations[0]],
-		...(options ?? {}),
+		...options,
 	});
 }
 

src/git/remotes/custom.ts

@@ -112,7 +112,7 @@ export class CustomRemote extends RemoteProvider {
 			repo: this.path,
 			repoBase: repoBase,
 			repoPath: repoPath,
-			...(additionalContext ?? {}),
+			...additionalContext,
 		};
 
 		for (const [key, value] of Object.entries(context)) {

src/plus/integrations/providers/github/githubGitProvider.ts

@@ -3071,9 +3071,9 @@ export class GitHubGitProvider implements GitProvider, Disposable {
 
 			const values = operations.get('commit:');
 			if (values != null) {
-				const commitsResults = await Promise.allSettled<Promise<GitCommit | undefined>[]>([
-					...map(values, v => this.getCommit(repoPath, v.replace(doubleQuoteRegex, ''))),
-				]);
+				const commitsResults = await Promise.allSettled(
+					map(values, v => this.getCommit(repoPath, v.replace(doubleQuoteRegex, ''))),
+				);
 
 				let i = 0;
 				for (const commitResult of commitsResults) {

src/quickpicks/repositoryPicker.ts

@@ -88,11 +88,11 @@ export async function showRepositoryPicker(
 
 	let items: RepositoryQuickPickItem[];
 	if (repositoriesOrOptions == null || Array.isArray(repositoriesOrOptions)) {
-		items = await Promise.all<Promise<RepositoryQuickPickItem>>([
-			...map(repositoriesOrOptions ?? Container.instance.git.openRepositories, r =>
+		items = await Promise.all<Promise<RepositoryQuickPickItem>>(
+			map(repositoriesOrOptions ?? Container.instance.git.openRepositories, r =>
 				createRepositoryQuickPickItem(r, undefined, { branch: true, status: true }),
 			),
-		]);
+		);
 	} else {
 		const { filter } = repositoriesOrOptions;
 		items = await filterMapAsync(Container.instance.git.openRepositories, async r =>
@@ -162,11 +162,11 @@ export async function showRepositoriesPicker(
 
 	let items: RepositoryQuickPickItem[];
 	if (repositoriesOrOptions == null || Array.isArray(repositoriesOrOptions)) {
-		items = await Promise.all<Promise<RepositoryQuickPickItem>>([
-			...map(repositoriesOrOptions ?? Container.instance.git.openRepositories, r =>
+		items = await Promise.all<Promise<RepositoryQuickPickItem>>(
+			map(repositoriesOrOptions ?? Container.instance.git.openRepositories, r =>
 				createRepositoryQuickPickItem(r, undefined, { branch: true, status: true }),
 			),
-		]);
+		);
 	} else {
 		const { filter } = repositoriesOrOptions;
 		items = await filterMapAsync(Container.instance.git.openRepositories, async r =>

src/telemetry/telemetry.ts

@@ -142,7 +142,7 @@ export class TelemetryService implements Disposable {
 				type: 'sendEvent',
 				name: name,
 				data: data,
-				global: new Map([...this.globalAttributes]),
+				global: new Map(this.globalAttributes),
 				startTime: startTime ?? Date.now(),
 				endTime: endTime ?? Date.now(),
 			});

src/webviews/webviewsController.ts

@@ -298,11 +298,9 @@ export class WebviewsController implements Disposable {
 						descriptor.title,
 						{ viewColumn: column, preserveFocus: options?.preserveFocus ?? false },
 						{
-							...{
-								enableCommandUris: true,
-								enableScripts: true,
-								localResourceRoots: [Uri.file(container.context.extensionPath)],
-							},
+							enableCommandUris: true,
+							enableScripts: true,
+							localResourceRoots: [Uri.file(container.context.extensionPath)],
 							...descriptor.webviewOptions,
 							...descriptor.webviewHostOptions,
 						},

webpack.config.js

@@ -756,7 +756,7 @@ class FantasticonPlugin {
 			return;
 		}
 
-		const fontConfig = { ...(loadedConfig ?? {}), ...(config ?? {}) };
+		const fontConfig = { ...loadedConfig, ...config };
 
 		// TODO@eamodio: Figure out how to add watching for the fontConfig.inputDir
 		// Maybe something like: https://github.com/Fridus/webpack-watch-files-plugin