add isTrial check for pro trial accounts

Author: sergiolms

src/plus/gk/account/subscription.ts

@@ -40,6 +40,7 @@ export interface SubscriptionPlan {
 	readonly startedOn: string;
 	readonly expiresOn?: string | undefined;
 	readonly organizationId: string | undefined;
+	readonly isTrial: boolean;
 }
 
 export interface SubscriptionAccount {
@@ -169,6 +170,7 @@ export function getSubscriptionPlan(
 	expiresOn?: Date,
 	cancelled: boolean = false,
 	nextTrialOptInDate?: string,
+	isTrial: boolean = false,
 ): SubscriptionPlan {
 	return {
 		id: id,
@@ -180,6 +182,7 @@ export function getSubscriptionPlan(
 		nextTrialOptInDate: nextTrialOptInDate,
 		startedOn: (startedOn ?? new Date()).toISOString(),
 		expiresOn: expiresOn != null ? expiresOn.toISOString() : undefined,
+		isTrial: isTrial,
 	};
 }
 
@@ -240,7 +243,7 @@ export function isSubscriptionExpired(subscription: Optional<Subscription, 'stat
 }
 
 export function isSubscriptionTrial(subscription: Optional<Subscription, 'state'>): boolean {
-	return subscription.plan.actual.id !== subscription.plan.effective.id;
+	return subscription.plan.effective.isTrial;
 }
 
 export function isSubscriptionInProTrial(subscription: Optional<Subscription, 'state'>): boolean {

src/plus/gk/account/subscriptionService.ts

@@ -722,7 +722,6 @@ export class SubscriptionService implements Disposable {
 		const days = proPreviewLengthInDays;
 		const subscription = getPreviewSubscription(days, this._subscription);
 		this.changeSubscription(subscription);
-
 		setTimeout(async () => {
 			const confirm: MessageItem = { title: 'Continue' };
 			const learn: MessageItem = { title: 'See Pro Features' };
@@ -1235,6 +1234,7 @@ export class SubscriptionService implements Disposable {
 						undefined,
 						new Date(subscription.previewTrial.startedOn),
 						new Date(subscription.previewTrial.expiresOn),
+						true,
 					),
 				},
 			};

src/plus/gk/checkin.ts

@@ -143,6 +143,7 @@ export function getSubscriptionFromCheckIn(
 			license.organizationId,
 			new Date(license.latestStartDate),
 			new Date(license.latestEndDate),
+			license.latestStatus === 'trial' || license.latestStatus === 'in_trial',
 		);
 	}
 
@@ -179,6 +180,7 @@ export function getSubscriptionFromCheckIn(
 			new Date(license.latestEndDate),
 			license.latestStatus === 'cancelled',
 			license.nextOptInDate ?? data.nextOptInDate,
+			license.latestStatus === 'trial' || license.latestStatus === 'in_trial',
 		);
 	}