Refactors integration ID lookup to use provider directly

Replaces passing the entire remote object with passing only its provider when determining integration IDs. Simplifies function signatures and clarifies usage, reducing unnecessary coupling to the remote.
(#4478, #4516)

Author: sergeibbb

src/git/models/remote.ts

@@ -51,7 +51,7 @@ export class GitRemote<TProvider extends RemoteProvider | undefined = RemoteProv
 	get maybeIntegrationConnected(): boolean | undefined {
 		if (!this.provider?.id) return false;
 
-		const integrationId = getIntegrationIdForRemote(this);
+		const integrationId = getIntegrationIdForRemote(this.provider);
 		if (integrationId == null) return false;
 
 		// Special case for GitHub, since we support the legacy GitHub integration
@@ -105,7 +105,7 @@ export class GitRemote<TProvider extends RemoteProvider | undefined = RemoteProv
 	}
 
 	async getIntegration(): Promise<GitHostIntegration | undefined> {
-		const integrationId = getIntegrationIdForRemote(this);
+		const integrationId = getIntegrationIdForRemote(this.provider);
 		return integrationId && this.container.integrations.get(integrationId, this.provider?.domain);
 	}
 
@@ -125,7 +125,7 @@ export class GitRemote<TProvider extends RemoteProvider | undefined = RemoteProv
 	}
 
 	supportsIntegration(): this is GitRemote<RemoteProvider> {
-		return Boolean(getIntegrationIdForRemote(this));
+		return Boolean(getIntegrationIdForRemote(this.provider));
 	}
 }
 

src/plus/integrations/utils/-webview/integration.utils.ts

@@ -4,8 +4,7 @@ import {
 	GitSelfManagedHostIntegrationId,
 	IssuesCloudHostIntegrationId,
 } from '../../../../constants.integrations';
-import type { GitRemote } from '../../../../git/models/remote';
-import type { RemoteProviderId } from '../../../../git/remotes/remoteProvider';
+import type { RemoteProvider, RemoteProviderId } from '../../../../git/remotes/remoteProvider';
 import type { IntegrationConnectedKey } from '../../models/integration';
 import { isAzureCloudDomain } from '../../providers/azureDevOps';
 import { isBitbucketCloudDomain } from '../../providers/bitbucket';
@@ -64,30 +63,30 @@ export function getIntegrationConnectedKey<T extends IntegrationIds>(
 }
 
 export function getIntegrationIdForRemote(
-	remote: GitRemote,
+	provider: RemoteProvider | undefined,
 ): GitCloudHostIntegrationId | GitSelfManagedHostIntegrationId | undefined {
-	switch (remote.provider?.id) {
+	switch (provider?.id) {
 		case 'azure-devops':
-			if (isAzureCloudDomain(remote.provider.domain)) {
+			if (isAzureCloudDomain(provider.domain)) {
 				return GitCloudHostIntegrationId.AzureDevOps;
 			}
-			return remote.provider.custom ? undefined : GitSelfManagedHostIntegrationId.AzureDevOpsServer;
+			return provider.custom ? undefined : GitSelfManagedHostIntegrationId.AzureDevOpsServer;
 		case 'bitbucket':
 		case 'bitbucket-server':
-			if (isBitbucketCloudDomain(remote.provider.domain)) {
+			if (isBitbucketCloudDomain(provider.domain)) {
 				return GitCloudHostIntegrationId.Bitbucket;
 			}
 			return GitSelfManagedHostIntegrationId.BitbucketServer;
 		case 'github':
-			if (remote.provider.domain != null && !isGitHubDotCom(remote.provider.domain)) {
-				return remote.provider.custom
+			if (provider.domain != null && !isGitHubDotCom(provider.domain)) {
+				return provider.custom
 					? GitSelfManagedHostIntegrationId.GitHubEnterprise
 					: GitSelfManagedHostIntegrationId.CloudGitHubEnterprise;
 			}
 			return GitCloudHostIntegrationId.GitHub;
 		case 'gitlab':
-			if (remote.provider.domain != null && !isGitLabDotCom(remote.provider.domain)) {
-				return remote.provider.custom
+			if (provider.domain != null && !isGitLabDotCom(provider.domain)) {
+				return provider.custom
 					? GitSelfManagedHostIntegrationId.GitLabSelfHosted
 					: GitSelfManagedHostIntegrationId.CloudGitLabSelfHosted;
 			}