Stops passing remote attribute from "Home"

in order to avoid setting an invalid remote.
(#4387, #4411)

Author: sergeibbb

src/commands/remoteProviders.ts

@@ -13,7 +13,7 @@ import type { CommandContext } from './commandContext';
 import { isCommandContextViewNodeHasRemote } from './commandContext.utils';
 
 export interface ConnectRemoteProviderCommandArgs {
-	remote: string;
+	remote?: string;
 	repoPath: string;
 }
 

src/git/models/repositoryShape.ts

@@ -14,6 +14,5 @@ export interface RepositoryShape {
 		integration?: { id: SupportedCloudIntegrationIds; connected: boolean };
 		supportedFeatures: RemoteProviderSupportedFeatures;
 		url?: string;
-		bestRemoteName?: string;
 	};
 }

src/git/utils/-webview/repository.utils.ts

@@ -94,7 +94,6 @@ export async function toRepositoryShapeWithProvider(
 				: undefined,
 			supportedFeatures: remote.provider.supportedFeatures,
 			url: await remote.provider.url({ type: RemoteResourceType.Repo }),
-			bestRemoteName: remote.name,
 		};
 		if (provider.integration?.id == null) {
 			provider.integration = undefined;

src/webviews/apps/shared/components/repo-button-group.ts

@@ -200,7 +200,7 @@ export class GlRepoButtonGroup extends GlElement {
 								<a
 									href=${createCommandLink<ConnectRemoteProviderCommandArgs>(
 										'gitlens.connectRemoteProvider',
-										{ remote: provider.bestRemoteName!, repoPath: repo.path },
+										{ repoPath: repo.path },
 									)}
 								>
 									Connect to ${repo.provider!.name}
@@ -228,7 +228,6 @@ export class GlRepoButtonGroup extends GlElement {
 				part="connect-icon"
 				appearance="toolbar"
 				href=${createCommandLink<ConnectRemoteProviderCommandArgs>('gitlens.connectRemoteProvider', {
-					remote: provider.bestRemoteName!,
 					repoPath: repo.path,
 				})}
 			>