Updates linting...

 - Fixes missing awaits in try/catch/finally
 - Renames unused variables

Author: eamodio

.eslintrc.base.json

@@ -179,43 +179,6 @@
 				"newlines-between": "never"
 			}
 		],
-		"@typescript-eslint/ban-types": [
-			"error",
-			{
-				"extendDefaults": false,
-				"types": {
-					"String": {
-						"message": "Use string instead",
-						"fixWith": "string"
-					},
-					"Boolean": {
-						"message": "Use boolean instead",
-						"fixWith": "boolean"
-					},
-					"Number": {
-						"message": "Use number instead",
-						"fixWith": "number"
-					},
-					"Symbol": {
-						"message": "Use symbol instead",
-						"fixWith": "symbol"
-					},
-					// "Function": {
-					// 	"message": "The `Function` type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with `new`.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape."
-					// },
-					"Object": {
-						"message": "The `Object` type actually means \"any non-nullish value\", so it is marginally better than `unknown`.\n- If you want a type meaning \"any object\", you probably want `Record<string, unknown>` instead.\n- If you want a type meaning \"any value\", you probably want `unknown` instead."
-					},
-					"{}": {
-						"message": "`{}` actually means \"any non-nullish value\".\n- If you want a type meaning \"any object\", you probably want `object` or `Record<string, unknown>` instead.\n- If you want a type meaning \"any value\", you probably want `unknown` instead.",
-						"fixWith": "object"
-					}
-					// "object": {
-					// 	"message": "The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).\nConsider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys."
-					// }
-				}
-			}
-		],
 		"@typescript-eslint/consistent-type-assertions": [
 			"error",
 			{
@@ -274,6 +237,8 @@
 			"error",
 			{ "ignoreArrowShorthand": true, "ignoreVoidOperator": true }
 		],
+		"@typescript-eslint/no-duplicate-type-constituents": "off", // Can't control `undefined` so its too noisy
+		"@typescript-eslint/no-empty-object-type": ["error", { "allowInterfaces": "with-single-extends" }],
 		"@typescript-eslint/no-explicit-any": "off",
 		"@typescript-eslint/no-inferrable-types": ["warn", { "ignoreParameters": true, "ignoreProperties": true }],
 		"@typescript-eslint/no-invalid-void-type": "off", // Seems to error on `void` return types
@@ -282,6 +247,7 @@
 		"@typescript-eslint/no-redundant-type-constituents": "off",
 		"@typescript-eslint/no-unnecessary-condition": "off",
 		"@typescript-eslint/no-unnecessary-boolean-literal-compare": "off",
+		"@typescript-eslint/no-unnecessary-type-parameters": "off", // https://github.com/typescript-eslint/typescript-eslint/issues/9705
 		"@typescript-eslint/no-unsafe-argument": "off",
 		"@typescript-eslint/no-unsafe-assignment": "off",
 		"@typescript-eslint/no-unsafe-call": "off",
@@ -291,10 +257,13 @@
 		"@typescript-eslint/no-unused-vars": [
 			"warn",
 			{
-				"args": "after-used",
+				"args": "all",
 				"argsIgnorePattern": "^_",
-				"ignoreRestSiblings": true,
-				"varsIgnorePattern": "^_$"
+				"caughtErrors": "all",
+				"caughtErrorsIgnorePattern": "^_",
+				"destructuredArrayIgnorePattern": "^_",
+				"varsIgnorePattern": "^_",
+				"ignoreRestSiblings": true
 			}
 		],
 		"@typescript-eslint/no-use-before-define": ["error", { "functions": false, "classes": false }],

package.json

@@ -18019,8 +18019,8 @@
 		"@types/react-dom": "17.0.21",
 		"@types/sortablejs": "1.15.8",
 		"@types/vscode": "1.82.0",
-		"@typescript-eslint/eslint-plugin": "7.18.0",
-		"@typescript-eslint/parser": "7.18.0",
+		"@typescript-eslint/eslint-plugin": "8.5.0",
+		"@typescript-eslint/parser": "8.5.0",
 		"@vscode/test-electron": "2.4.1",
 		"@vscode/test-web": "0.0.60",
 		"@vscode/vsce": "3.1.0",

src/ai/openaiProvider.ts

@@ -403,7 +403,7 @@ Do not make any assumptions or invent details that are not supported by the code
 		}
 
 		try {
-			return fetch(url, {
+			return await fetch(url, {
 				headers: {
 					Accept: 'application/json',
 					'Content-Type': 'application/json',

src/annotations/gutterBlameAnnotationProvider.ts

@@ -50,7 +50,7 @@ export class GutterBlameAnnotationProvider extends BlameAnnotationProviderBase {
 	}
 
 	@log()
-	override async onProvideAnnotation(context?: AnnotationContext, state?: AnnotationState): Promise<boolean> {
+	override async onProvideAnnotation(_context?: AnnotationContext, state?: AnnotationState): Promise<boolean> {
 		const scope = getLogScope();
 
 		const blame = await this.getBlame(state?.recompute);

src/annotations/gutterHeatmapBlameAnnotationProvider.ts

@@ -22,7 +22,7 @@ export class GutterHeatmapBlameAnnotationProvider extends BlameAnnotationProvide
 	}
 
 	@log()
-	override async onProvideAnnotation(context?: AnnotationContext, state?: AnnotationState): Promise<boolean> {
+	override async onProvideAnnotation(_context?: AnnotationContext, state?: AnnotationState): Promise<boolean> {
 		const scope = getLogScope();
 
 		const blame = await this.getBlame(state?.recompute);

src/api/api.ts

@@ -32,7 +32,8 @@ export class Api implements GitLensApi {
 }
 
 export function preview() {
-	return (target: any, key: string, descriptor: PropertyDescriptor) => {
+	return (_target: any, _key: string, descriptor: PropertyDescriptor) => {
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
 		let fn: Function | undefined;
 		if (typeof descriptor.value === 'function') {
 			fn = descriptor.value;

src/avatars.ts

@@ -213,7 +213,7 @@ function getAvatarUriFromGitHubNoReplyAddress(email: string, size: number = 16):
 
 async function getAvatarUriFromRemoteProvider(
 	avatar: Avatar,
-	key: string,
+	_key: string,
 	email: string,
 	repoPathOrCommit: string | { ref: string; repoPath: string },
 	{ size = 16 }: { size?: number } = {},

src/commands/base.ts

@@ -515,7 +515,7 @@ export abstract class EditorCommand implements Disposable {
 		this._disposable.dispose();
 	}
 
-	private executeCore(command: string, editor: TextEditor, edit: TextEditorEdit, ...args: any[]): any {
+	private executeCore(_command: string, editor: TextEditor, edit: TextEditorEdit, ...args: any[]): any {
 		return this.execute(editor, edit, ...args);
 	}
 

src/commands/diffWithRevision.ts

@@ -111,7 +111,7 @@ export class DiffWithRevisionCommand extends ActiveEditorCommand {
 				picked: gitUri.sha,
 				keyboard: {
 					keys: ['right', 'alt+right', 'ctrl+right'],
-					onDidPressKey: async (key, item) => {
+					onDidPressKey: async (_key, item) => {
 						await executeCommand<DiffWithCommandArgs>(Commands.DiffWith, {
 							repoPath: gitUri.repoPath,
 							lhs: {

src/commands/diffWithWorking.ts

@@ -107,7 +107,7 @@ export class DiffWithWorkingCommand extends ActiveEditorCommand {
 				placeholder: 'Choose another working file to open',
 				keyboard: {
 					keys: ['right', 'alt+right', 'ctrl+right'],
-					onDidPressKey: async (key, uri) => {
+					onDidPressKey: async (_key, uri) => {
 						await findOrOpenEditor(uri, { ...args.showOptions, preserveFocus: true, preview: true });
 					},
 				},