Skip to content

Commit 18837cb

Browse files
committed
Adds tooltips to focus view
1 parent d76af58 commit 18837cb

File tree

3 files changed

+21
-14
lines changed

3 files changed

+21
-14
lines changed

src/webviews/apps/plus/focus/components/gk-issue-row.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -127,14 +127,18 @@ export class GkIssueRow extends LitElement {
127127
<gk-badge>pending suggestions</gk-badge> -->
128128
</p>
129129
<p>
130-
<gk-tag variant="ghost">
131-
<span slot="prefix"><code-icon icon="comment-discussion"></code-icon></span>
132-
${this.issue.commentsCount}
133-
</gk-tag>
134-
<gk-tag variant="ghost">
135-
<span slot="prefix"><code-icon icon="thumbsup"></code-icon></span>
136-
${this.issue.thumbsUpCount}
137-
</gk-tag>
130+
<gk-tooltip
131+
><gk-tag variant="ghost" slot="trigger">
132+
<span slot="prefix"><code-icon icon="comment-discussion"></code-icon></span>
133+
${this.issue.commentsCount} </gk-tag
134+
><span>Comments</span></gk-tooltip
135+
>
136+
<gk-tooltip
137+
><gk-tag variant="ghost" slot="trigger">
138+
<span slot="prefix"><code-icon icon="thumbsup"></code-icon></span>
139+
${this.issue.thumbsUpCount} </gk-tag
140+
><span>Thumbs Up</span></gk-tooltip
141+
>
138142
</p>
139143
<span slot="people">
140144
<gk-avatar-group>

src/webviews/apps/plus/focus/components/gk-pull-request-row.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,13 @@ export class GkPullRequestRow extends LitElement {
211211
<span slot="additions">${this.pullRequest.additions}</span>
212212
<span slot="deletions">${this.pullRequest.deletions}</span>
213213
</gk-additions-deletions>
214-
<gk-tag variant="ghost">
215-
<span slot="prefix"><code-icon icon="comment-discussion"></code-icon></span>
216-
${this.pullRequest.comments}
217-
</gk-tag>
214+
<gk-tooltip>
215+
<gk-tag variant="ghost" slot="trigger">
216+
<span slot="prefix"><code-icon icon="comment-discussion"></code-icon></span>
217+
${this.pullRequest.comments}
218+
</gk-tag>
219+
<span>Comments</span>
220+
</gk-tooltip>
218221
</p>
219222
<span slot="people">
220223
<gk-avatar-group>

src/webviews/apps/plus/focus/components/gk-theme.css.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ export const themeProperties = css`
2121
--gk-button-outline-color-active: var(--background-10);
2222
--gk-button-outline-color-disabled: var(--color-foreground--50);
2323
24-
--gk-tooltip-background-color: var(--popover-bg);
25-
--gk-tooltip-font-color: var(--color-foreground);
24+
--gk-tooltip-background-color: var(--popover-bg); // var(--vscode-editorHoverWidget-background);
25+
--gk-tooltip-font-color: var(--color-foreground); // var(--vscode-editorHoverWidget-foreground);
2626
--gk-tooltip-font-weight: normal;
2727
--gk-tooltip-font-size: 1.2rem;
2828
}

0 commit comments

Comments
 (0)